From owner-cvs-sys Sun Apr 7 01:19:20 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id BAA28687 for cvs-sys-outgoing; Sun, 7 Apr 1996 01:19:20 -0800 (PST) Received: from mpp.minn.net (root@p100.isc.net [206.144.132.100]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id BAA28678 Sun, 7 Apr 1996 01:19:13 -0800 (PST) Received: (from mpp@localhost) by mpp.minn.net (8.7.5/8.6.9) id EAA24688; Sun, 7 Apr 1996 04:18:52 -0500 (CDT) Message-Id: <199604070918.EAA24688@mpp.minn.net> Subject: Re: cvs commit: src/sys/pccard pccard.c pcic.c To: gpalmer@FreeBSD.ORG (Gary Palmer) Date: Sun, 7 Apr 1996 04:18:51 -0500 (CDT) From: "Mike Pritchard" Cc: bde@zeta.org.au, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Reply-To: mpp@FreeBSD.ORG In-Reply-To: <1486.828867685@palmer.demon.co.uk> from "Gary Palmer" at Apr 7, 96 10:01:25 am X-Mailer: ELM [version 2.4 PL25 ME8b] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Gary Palmer wrote: > > Bruce Evans wrote in message ID > <199604060739.RAA15696@godzilla.zeta.org.au>: > > > Modified: sys/pccard pccard.c pcic.c > > > Log: > > > pccard.c: > > > #include to get sysbeep() prototype > > > > This should be #include . pccard isn't supposed to > > have any i386 dependencies. Similarly for i386/include/laptops.h and > > a few other i386/include's. Don't change this - I'll commit it later. > > I agree, it shouldn't have any i386 dependencies, but using > will just mean that it's dependant on the contents > of /usr/include matching whats in /sys/, which is one reason that I > chose to use the path. I thought we were trying to make > the kernel tree self-contained and not refer to /usr/include if at all > possible? Config should have already created the appropriate symlink for you to make this possible: # ls -l /usr/src/sys/compile/mpp/machine lrwxrwx--- 1 root src 18 Apr 5 19:17 /usr/src/sys/compile/mpp/machine@ -> ../../i386/include -- Mike Pritchard mpp@freebsd.org "Go that way. Really fast. If something gets in your way, turn"