From owner-freebsd-current  Mon Apr  8 11:39:36 2002
Delivered-To: freebsd-current@freebsd.org
Received: from tao.org.uk (genius.tao.org.uk [212.135.162.51])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4E64137B400; Mon,  8 Apr 2002 11:39:30 -0700 (PDT)
Received: by tao.org.uk (Postfix, from userid 100)
	id 925A5410; Mon,  8 Apr 2002 19:38:29 +0100 (BST)
Date: Mon, 8 Apr 2002 19:38:29 +0100
From: Josef Karthauser <joe@tao.org.uk>
To: John Baldwin <jhb@FreeBSD.org>
Cc: current@freebsd.org, David Wolfskill <david@catwhisker.org>
Subject: Re: panic "sleeping without a mutex" in usb_task_thread
Message-ID: <20020408183829.GB85649@genius.tao.org.uk>
Mail-Followup-To: Josef Karthauser <joe@tao.org.uk>,
	John Baldwin <jhb@FreeBSD.org>, current@freebsd.org,
	David Wolfskill <david@catwhisker.org>
References: <20020408175952.GA83305@genius.tao.org.uk> <XFMail.20020408133755.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="IiVenqGWf+H9Y6IX"
Content-Disposition: inline
In-Reply-To: <XFMail.20020408133755.jhb@FreeBSD.org>
User-Agent: Mutt/1.3.28i
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


--IiVenqGWf+H9Y6IX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 08, 2002 at 01:37:55PM -0400, John Baldwin wrote:
>=20
> On 08-Apr-2002 Josef Karthauser wrote:
> > On Mon, Apr 08, 2002 at 12:33:40PM -0400, John Baldwin wrote:
> > =20
> >> show witness isn't useful to most people so I would avoid it unless so=
meone
> >> explicitly asks for it.  The problem here is likely due to the
> >> usb_task_thread() not locking Giant when it starts up.
> >=20
> > We probably want this:
>=20
> Probably unless some USB specific locks are added instead, but this is the
> easier fix for the time being.
>=20

Cool.  I've committed this; where should I look to get a low down on
what to lock, when and how?  Is there anything other than source to
refer to?

Joe

--IiVenqGWf+H9Y6IX
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAjyx46UACgkQXVIcjOaxUBZAqQCg1oToZIx39FaVjneiNDZo2dOr
ZYEAmgIXJx37w3dhK+MNObBxNrnFdeVn
=ftAp
-----END PGP SIGNATURE-----

--IiVenqGWf+H9Y6IX--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message