From owner-cvs-CVSROOT Wed Aug 23 10:43:48 1995 Return-Path: cvs-CVSROOT-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id KAA14267 for cvs-CVSROOT-outgoing; Wed, 23 Aug 1995 10:43:48 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id KAA14257 ; Wed, 23 Aug 1995 10:43:41 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id KAA09741; Wed, 23 Aug 1995 10:41:35 -0700 From: "Rodney W. Grimes" Message-Id: <199508231741.KAA09741@gndrsh.aac.dev.com> Subject: Re: cvs commit: CVSROOT cvsedit To: peter@haywire.dialix.com (Peter Wemm) Date: Wed, 23 Aug 1995 10:41:35 -0700 (PDT) Cc: CVS-commiters@freefall.FreeBSD.org, cvs-CVSROOT@freefall.FreeBSD.org In-Reply-To: from "Peter Wemm" at Aug 23, 95 09:49:33 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1821 Sender: cvs-CVSROOT-owner@FreeBSD.org Precedence: bulk > > On Wed, 23 Aug 1995, Rodney W. Grimes wrote: > > > peter 95/08/23 04:42:35 > > > > > > Modified: . cvsedit > > > Log: > > > Fix incorrect Regexp that zapped Satoshi's Submitted-by line.. :-( > > > This got past both Rod and I.. :-( > > > > :-(. I guess we better get a third set of eyes to look things over from > > here on out. Can I have an ``expert'' class perl hacker get in contact > > with me for just such reviews? > > > > Peter has several more changes (and so do I) to the perl scripts used to > > smarten up cvs, and it looks like we better send them out to a third > > set of eyes looking for this type of stuff. > > Also, about the lack of review on this change.. This was an incredibly > obvious fix once the existance of the problem was known.. :-( > > It was pretty important to get it in ASAP, and when (apparently) nobody > was around to bounce it off, I dived in. > > I have a suggestion for this sort of thing in the future.. When > *initiating* changes to the CVSROOT perl scripts, how about we email the > diff to cvs-commmitters first, and let it stew for 24 hours. > > It'd be much more likely that some of the 60 or so pairs of eyes would > pick up this sort of editing slip. It's the perl "literate, but non-guru" > types who would most likely pick up the logic problems, as they would not > be quite as distracted by the construction of the expressions. Let it be said, let it be written (ok, so we need a FreeFall cvs Handbook), CVSROOT script changes shall be reviewed by -committers for a 24 hour period before commit as even very small errors here can be fatal if not majorly painful. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD