From owner-freebsd-current@FreeBSD.ORG Mon Aug 25 14:19:52 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1ADE1065681; Mon, 25 Aug 2008 14:19:52 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:610:652::211]) by mx1.freebsd.org (Postfix) with ESMTP id 49BF68FC15; Mon, 25 Aug 2008 14:19:52 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 625641CE37; Mon, 25 Aug 2008 16:19:51 +0200 (CEST) Date: Mon, 25 Aug 2008 16:19:51 +0200 From: Ed Schouten To: Kris Kennaway Message-ID: <20080825141951.GB99951@hoeg.nl> References: <200808241520.m7OFKiKx018944@svn.freebsd.org> <48B2B7A7.1030907@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VhTfnZMp4IyRFcf/" Content-Disposition: inline In-Reply-To: <48B2B7A7.1030907@FreeBSD.org> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: FreeBSD Current Subject: Re: mouse interactivity (Re: svn commit: r182109 - head/sys/dev/syscons) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2008 14:19:52 -0000 --VhTfnZMp4IyRFcf/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Kris Kennaway wrote: > Ed Schouten wrote: >> Author: ed >> Date: Sun Aug 24 15:20:44 2008 >> New Revision: 182109 >> URL: http://svn.freebsd.org/changeset/base/182109 >> >> Log: >> Make sysmouse(4) use its own locks, instead of using Giant. >> When I changed syscons(4) to work with the MPSAFE TTY code, I just >> locked all device nodes down using the compatibility feature that allo= ws >> you to override the TTY's lock (Giant in this case). Upon closer >> inspection, it seems sysmouse(4) only has two internal variables that >> need locking: mouse_level and mouse_status. >> I haven't done any performance benchmarks on this, though I think=20 >> it >> won't have any dramatic improvements on the system. It is good to get >> rid of Giant here, because the third argument of tty_alloc() has only >> been added to ease migration to MPSAFE TTY. It should not be used when >> not needed. >> While there, remove SC_MOUSE, which is a leftover from the MPSAFE=20 >> TTY >> import. > > This might help mouse interactivity for desktop users that have legacy = =20 > Giant-locked systems in use (e.g. busy MSDOS filesystems, giant-locked = =20 > disk drivers), etc. Yes, but only a very very little bit. moused still delivers the input to /dev/consolectl, which is still Giant locked. The part where the Xorg server reads from /dev/sysmouse is now Giant-free. --=20 Ed Schouten WWW: http://80386.nl/ --VhTfnZMp4IyRFcf/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkiyv4cACgkQ52SDGA2eCwVGKACfYIsmQia1C741Gaunf5Tq68zX EL8An0gPZx5PF4DpNy1E+DsPF0dRV7mN =tgIW -----END PGP SIGNATURE----- --VhTfnZMp4IyRFcf/--