From owner-freebsd-current Fri Jan 29 17:11:03 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA17037 for freebsd-current-outgoing; Fri, 29 Jan 1999 17:11:03 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA17017 for ; Fri, 29 Jan 1999 17:10:54 -0800 (PST) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id RAA02261; Fri, 29 Jan 1999 17:07:09 -0800 (PST) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpdwC2256; Sat Jan 30 01:07:04 1999 Date: Fri, 29 Jan 1999 17:07:00 -0800 (PST) From: Julian Elischer To: Greg Lehey cc: Warner Losh , current@FreeBSD.ORG Subject: Re: btokup().. patch to STYLE(9) (fwd) In-Reply-To: <19990130104943.W8473@freebie.lemis.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 30 Jan 1999, Greg Lehey wrote: > of intelligibility. Consider one possible expansion > > if (((allocationfail | (IGNOREFAILUREMASK & (incount % BLKSIZE))) ^ failures) != 0) or if (((allocationfail | (IGNOREFAILUREMASK & (incount % BLKSIZE))) ^ failures) != 0) > > (yes, this still doesn't make sense, but I can't be bothered to look > for something more appropriate) This is now 99 characters wide, and > it's the kind of code which doesn't gain in legibility by being broken > into multiple lines, I'll say.. I tried several different splits.. the above is as good as I can get it or me.. > especially if the indentation of the follow-on > lines is independent of the structure of the expression. bde has made > it clear he considers code more than 80 characters wide to be Evil. > Question: how many people still limit their editor windows to 80 > characters? I do These cases are rather rare for me, but sometimes I have to split like shwon. Sometimes I'll use a temp variable and sometimes I'll look to see if a macro can be used if parts of the test are done more than once. The trouble with > 80 chars is that the console is 80 chars wide.. :-) julian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message