From owner-svn-src-all@freebsd.org Wed Feb 27 00:49:20 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6F4D150A38B; Wed, 27 Feb 2019 00:49:20 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6AE8B8427E; Wed, 27 Feb 2019 00:49:20 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 1C6DD3C475F; Wed, 27 Feb 2019 00:49:19 +0000 (UTC) Date: Wed, 27 Feb 2019 00:49:19 +0000 From: Brooks Davis To: "K. Macy" Cc: Matt Macy , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Subject: Re: svn commit: r344487 - in head/sys: conf gnu/gcov Message-ID: <20190227004919.GJ47081@spindle.one-eyed-alien.net> References: <201902232114.x1NLE0cH085345@repo.freebsd.org> <20190225175809.GB47081@spindle.one-eyed-alien.net> <20190226175248.GF47081@spindle.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JIpyCmsTxyPLrmrM" Content-Disposition: inline In-Reply-To: <20190226175248.GF47081@spindle.one-eyed-alien.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 6AE8B8427E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.89 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.89)[-0.894,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 00:49:21 -0000 --JIpyCmsTxyPLrmrM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 26, 2019 at 05:52:48PM +0000, Brooks Davis wrote: > On Mon, Feb 25, 2019 at 05:11:26PM -0800, K. Macy wrote: > > > An additional issue is that the a warning tag was not added to > > > sys/conf/files. A warning along the lines of: > > > > > > warning "kernel contains GPLv2 licensed GCOV" > > > > > > needs to be added. > >=20 > > Yup. > >=20 > > > > > > This commit needed more through review. > >=20 > > How would this be achieved:? I had several people on the review and no > > one had substantive feedback. >=20 > For GPL stuff, add #core to the reviewers list and feel free to drop us > an email to make sure we see it promptly. FYI, we've had phab-admin@ add a herald rule to add #core as a reviewer automatically for changes that add new lines containing either the SPDX tag or the string "GNU General Public License". Hopefully this will limit future drama in this area. Documentation updates are in also in progress. -- Brooks --JIpyCmsTxyPLrmrM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJcdd6OAAoJEKzQXbSebgfAizkH/jD7L34cKSRNqhZ2iNmG9FiS oOHhe2f8Q41j9avkM/RzsSH3Z70d9Aub1agsoM0G0dL4AZvF2lp4gYq/iYZKNypA aikEcuJgUQiESuv6LuDk/jU6RRF4uaqswjWiF8XejNReHiwHyTXegVD85sPKQDPu iqju4HAkNP9ekDeZ/mQGZGGi4mDhw0g9xZ7JPv9xDiB0Xr53bLCMhrBjhLPgBsEI AsofBWC2bI30JFbsaVMUTDhbLooXzQuE+/EA/whO07E4xrzrk5x1iRAHQielvDWs y4X14G2b9mQwhDlb/Gv5o1IM0XNcKRs4EM1EXMkbl36Xq21/QVfWQVTvC2JcTZA= =BvMM -----END PGP SIGNATURE----- --JIpyCmsTxyPLrmrM--