From owner-freebsd-fs@FreeBSD.ORG  Tue Sep  7 22:50:03 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 425E610656AA
	for <freebsd-fs@hub.freebsd.org>; Tue,  7 Sep 2010 22:50:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 182D08FC1B
	for <freebsd-fs@hub.freebsd.org>; Tue,  7 Sep 2010 22:50:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o87Mo2Qm059557
	for <freebsd-fs@freefall.freebsd.org>; Tue, 7 Sep 2010 22:50:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o87Mo2KY059556;
	Tue, 7 Sep 2010 22:50:02 GMT (envelope-from gnats)
Date: Tue, 7 Sep 2010 22:50:02 GMT
Message-Id: <201009072250.o87Mo2KY059556@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/150143: commit references a PR
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Sep 2010 22:50:03 -0000

The following reply was made to PR kern/150143; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/150143: commit references a PR
Date: Tue,  7 Sep 2010 22:41:09 +0000 (UTC)

 Author: ivoras
 Date: Tue Sep  7 22:40:45 2010
 New Revision: 212305
 URL: http://svn.freebsd.org/changeset/base/212305
 
 Log:
   Avoid "Entry can disappear before we lock fdvp" panic.
   
   PR:		150143
   Submitted by:	Gleb Kurtsou <gk at FreeBSD.org>
   Pretty sure it won't blow up: mckusick
   MFC after:	2 weeks
 
 Modified:
   head/sys/fs/tmpfs/tmpfs_vnops.c
 
 Modified: head/sys/fs/tmpfs/tmpfs_vnops.c
 ==============================================================================
 --- head/sys/fs/tmpfs/tmpfs_vnops.c	Tue Sep  7 21:28:45 2010	(r212304)
 +++ head/sys/fs/tmpfs/tmpfs_vnops.c	Tue Sep  7 22:40:45 2010	(r212305)
 @@ -981,10 +981,14 @@ tmpfs_rename(struct vop_rename_args *v)
  	fnode = VP_TO_TMPFS_NODE(fvp);
  	de = tmpfs_dir_lookup(fdnode, fnode, fcnp);
  
 -	/* Avoid manipulating '.' and '..' entries. */
 +	/* Entry can disappear before we lock fdvp,
 +	 * also avoid manipulating '.' and '..' entries. */
  	if (de == NULL) {
 -		MPASS(fvp->v_type == VDIR);
 -		error = EINVAL;
 +		if ((fcnp->cn_flags & ISDOTDOT) != 0 ||
 +		    (fcnp->cn_namelen == 1 && fcnp->cn_nameptr[0] == '.'))
 +			error = EINVAL;
 +		else
 +			error = ENOENT;
  		goto out_locked;
  	}
  	MPASS(de->td_node == fnode);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"