From owner-cvs-all@FreeBSD.ORG  Wed Nov 30 19:04:11 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 57B3B16A41F;
	Wed, 30 Nov 2005 19:04:11 +0000 (GMT) (envelope-from flz@FreeBSD.org)
Received: from smtp.xbsd.org (xbsd.org [82.233.2.192])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 424B043D64;
	Wed, 30 Nov 2005 19:04:10 +0000 (GMT) (envelope-from flz@FreeBSD.org)
Received: from localhost (localhost.xbsd.org [127.0.0.1])
	by smtp.xbsd.org (Postfix) with ESMTP id 1A738119B2;
	Wed, 30 Nov 2005 20:04:08 +0100 (CET)
Received: from smtp.xbsd.org ([127.0.0.1])
	by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new,
	port 10024) with ESMTP
	id 51595-06; Wed, 30 Nov 2005 20:03:59 +0100 (CET)
Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6])
	by smtp.xbsd.org (Postfix) with ESMTP id 781AB11934;
	Wed, 30 Nov 2005 20:03:59 +0100 (CET)
From: Florent Thoumie <flz@FreeBSD.org>
To: Kris Kennaway <kris@obsecurity.org>
In-Reply-To: <20051130183717.GA71920@xor.obsecurity.org>
References: <200511301510.jAUFACmr038837@repoman.freebsd.org>
	<20051130161657.GA65549@FreeBSD.org>
	<1133371126.1219.23.camel@cream.xbsd.org>
	<20051130183717.GA71920@xor.obsecurity.org>
Content-Type: text/plain; charset=utf-8
Date: Wed, 30 Nov 2005 20:03:19 +0000
Message-Id: <1133380999.1219.30.camel@cream.xbsd.org>
Mime-Version: 1.0
X-Mailer: Evolution 2.4.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: amavisd-new at xbsd.org
Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/shells/bash Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Nov 2005 19:04:11 -0000

Le Mercredi 30 novembre 2005 à 13:37 -0500, Kris Kennaway a écrit :
> On Wed, Nov 30, 2005 at 05:18:46PM +0000, Florent Thoumie wrote:
> > Le Mercredi 30 novembre 2005 ?? 16:16 +0000, Alexey Dokuchaev a ??crit :
> > > On Wed, Nov 30, 2005 at 03:10:12PM +0000, Florent Thoumie wrote:
> > > > flz         2005-11-30 15:10:12 UTC
> > > > 
> > > >   FreeBSD ports repository
> > > > 
> > > >   Modified files:
> > > >     shells/bash          Makefile 
> > > >   Log:
> > > >   - Add WANT_STATIC_BASH knob.
> > > 
> > > WANT_ prefix belongs to bpm's internal namespace; it should not be used
> > > this way.
> > 
> > 	Agreed, Pav made the same notice but :
> > 
> > 	1) that's not my port and,
> 
> Don't commit bogus changes, and
> 
> > 	2) shells/bash2 has the same exact construction.
> 
> fix bogus changes when you encounter them.

	I'll send a PR with s/WANT/WITH/ later and will commit the fix
	in two weeks with maintainer timeout.

-- 
Florent Thoumie
flz@FreeBSD.org
FreeBSD committer