From owner-dev-commits-src-main@freebsd.org Mon Mar 1 17:54:01 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F0071566584; Mon, 1 Mar 2021 17:54:01 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dq7DT6MlCz3HSd; Mon, 1 Mar 2021 17:54:01 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (unknown [IPv6:2601:405:4a00:acd:85ea:d09e:32a:9875]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: nwhitehorn/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 7407734F9E; Mon, 1 Mar 2021 17:54:01 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) To: Kyle Evans Cc: Brandon Bergren , Warner Losh , Kevin Bowling , Jessica Clarke , Colin Percival , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202102232124.11NLOT27012354@gitrepo.freebsd.org> <583f83d8-c78b-d961-d2c5-9693bd36563b@freebsd.org> <743fd126-2077-49b1-9c85-7ccc61616b98@www.fastmail.com> <460ceb98-e0c1-42b3-8e3c-2587c5ce8398@www.fastmail.com> <8215cd95-6905-49da-ab07-65796845613c@www.fastmail.com> <82f307a1-d7e2-0950-510d-148a1a7e61a2@freebsd.org> From: Nathan Whitehorn Subject: Re: git: 0b7472b3d8d2 - main - Mount the EFI system partition (ESP) on newly-installed systems. Message-ID: Date: Mon, 1 Mar 2021 12:54:00 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 17:54:02 -0000 On 3/1/21 11:50 AM, Kyle Evans wrote: > On Mon, Mar 1, 2021 at 10:45 AM Nathan Whitehorn wrote: >> >> >> On 3/1/21 11:42 AM, Kyle Evans wrote: >>> On Mon, Mar 1, 2021 at 10:39 AM Nathan Whitehorn wrote: >>>> >>>> On 2/28/21 3:44 PM, Brandon Bergren wrote: >>>>> On Sun, Feb 28, 2021, at 2:25 PM, Warner Losh wrote: >>>>>> Yes. I agree as well. I was just hoping to say just that: EFI is b= arely >>>>>> theoretically possible, but in reality we'll likely never use it..= =2E. >>>>>> >>>>>> The net effect is that we don't want to install efi on powerpc on = freebsd. >>>>>> >>>>>> Warner >>>>>> >>>>> Yeah. The code before the change excluded mips and powerpc platform= s, and it should continue to do so instead of using the existence of a /b= oot/efi directory as the only clue. >>>>> >>>>> Currently bsdinstall bails out and leaves powerpc* in a half-instal= led state because the die in the uname case propagates to the main script= , so it never runs the bits after the bootconfig. >>>>> >>>> So that was a deliberate choice to keep the list of places that know= >>>> about efi vs. non-EFI centralized. I'd prefer to just not make that >>>> directory on systems where it doesn't apply rather than messing with= the >>>> installer. Do you know where it is being made? >>>> -Nathan >>> It's part of the hierarchy in ^/etc/mtree/BSD.root.dist >>> >> Is there a reason it needs to be? The installer bits all make it when >> needed already, so just removing it there seems like the simplest path= =2E > I can't think of a reason, as long as both the release(7) scripts and > the installer create it as needed -- I note that vmimage.subr seems to > create it itself, but arm.subr seems to get it wrong atm. It'll need > to create /boot/efi for PART_SCHEME =3D=3D GPT, and /boot/msdos should > probably be scoped down to PART_SCHEME =3D=3D MBR where it's used at th= e > moment. > The /boot/uboot in BSD.root.dist also looks like cruft to me, but maybe=20 best to leave for now? -Nathan