From owner-svn-src-head@FreeBSD.ORG  Wed May 28 14:12:48 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 38B3FE09;
 Wed, 28 May 2014 14:12:48 +0000 (UTC)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "vps1.elischer.org",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0AD942B5B;
 Wed, 28 May 2014 14:12:47 +0000 (UTC)
Received: from jre-mbp.elischer.org
 (ppp121-45-232-70.lns20.per1.internode.on.net [121.45.232.70])
 (authenticated bits=0)
 by vps1.elischer.org (8.14.8/8.14.8) with ESMTP id s4SECbaa091341
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
 Wed, 28 May 2014 07:12:40 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Message-ID: <5385EED0.1010506@freebsd.org>
Date: Wed, 28 May 2014 22:12:32 +0800
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org,
 dmitryluhtionov@gmail.com
Subject: Re: svn commit: r266806 - head/sys/netgraph
References: <201405281315.s4SDFEvc061176@svn.freebsd.org>
In-Reply-To: <201405281315.s4SDFEvc061176@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 May 2014 14:12:48 -0000

On 5/28/14, 9:15 PM, Gleb Smirnoff wrote:
> Author: glebius
> Date: Wed May 28 13:15:14 2014
> New Revision: 266806
> URL: http://svnweb.freebsd.org/changeset/base/266806
>
> Log:
>    Use M_WAITOK for the NGM_PIPE_SET_CFG control message. We expect it to
>    arrive from userland only.
>    
>    Submitted by:	Dmitry Luhtionov <dmitryluhtionov gmail.com>
what's to stop another node from generating it and sending it on?
generally a message may come from anywhere.
Just becasue YOU don't have module that
sends messages to ng_pipe, doesn't mean there never will be..
also there are cases when the locking may force a message to be 
delivered asynchronously.


>
> Modified:
>    head/sys/netgraph/ng_pipe.c
>
> Modified: head/sys/netgraph/ng_pipe.c
> ==============================================================================
> --- head/sys/netgraph/ng_pipe.c	Wed May 28 13:06:53 2014	(r266805)
> +++ head/sys/netgraph/ng_pipe.c	Wed May 28 13:15:14 2014	(r266806)
> @@ -471,7 +471,7 @@ parse_cfg(struct ng_pipe_hookcfg *curren
>   		if (hinfo->ber_p == NULL)
>   			hinfo->ber_p =
>   			    malloc((MAX_FSIZE + MAX_OHSIZE) * sizeof(uint64_t),
> -			    M_NG_PIPE, M_NOWAIT);
> +			    M_NG_PIPE, M_WAITOK);
>   		current->ber = new->ber;
>   
>   		/*
>
>