From owner-svn-ports-head@FreeBSD.ORG  Thu Nov  1 18:08:19 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id DD6E4B48;
 Thu,  1 Nov 2012 18:08:19 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
 [209.85.214.54])
 by mx1.freebsd.org (Postfix) with ESMTP id E48848FC08;
 Thu,  1 Nov 2012 18:08:18 +0000 (UTC)
Received: by mail-bk0-f54.google.com with SMTP id jf20so1263724bkc.13
 for <multiple recipients>; Thu, 01 Nov 2012 11:08:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date
 :x-google-sender-auth:message-id:subject:to:cc:content-type;
 bh=tluxdU22sg/bO28p8TG5pW5PbIH2BurZC9YDTBOJrBY=;
 b=PMy6KLRSu0/va8o4csaEVSt5ugp0ozUtBgxz9qwb+6FwAuGuxuEHBmuaf/tccgajC+
 Dbpy5dvUhxGcrb5PJioosg9hjzZUEFOVgIlY478g0UIyIIYmEAc3tXe2VvVAAnbMHB4s
 PfqEO98voe/pfkip06nLBCGdkWCVm8F+X9RPXLhUoKXUEHooC/Z594upWg7xyW2LrfMJ
 p7l0aBvhGPgqepMwA6QnRvi9LTQrJbLzJAVvwcGH+7EBSyy7SZ58sZ9IZ6GKruhS+nCc
 yg2mlP/9qC+g9bEU29zkEiAO3t/y9EmE3Ed8T5Wpwe5mLy0Phlju6zPbGMGr6qSyYQ71
 gvSQ==
Received: by 10.204.11.207 with SMTP id u15mr12610308bku.40.1351793297634;
 Thu, 01 Nov 2012 11:08:17 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.204.50.197 with HTTP; Thu, 1 Nov 2012 11:07:47 -0700 (PDT)
In-Reply-To: <201210312155.q9VLtPMA040921@svn.freebsd.org>
References: <201210312155.q9VLtPMA040921@svn.freebsd.org>
From: Chris Rees <crees@FreeBSD.org>
Date: Thu, 1 Nov 2012 18:07:47 +0000
X-Google-Sender-Auth: eliYw-edxHqnxIG5qav8eD8Kirg
Message-ID: <CADLo8398pEz3gRPfxsWA_0z3n92gC=A0mZ-x9R0wefYKFmQa1g@mail.gmail.com>
Subject: Re: svn commit: r306768 - in head/www/squid32: . files
To: Florian Smeets <flo@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, tmseck@web.de,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2012 18:08:19 -0000

On 31 October 2012 21:55, Florian Smeets <flo@freebsd.org> wrote:
> XXX Ports RC script present
> Author: flo
> Date: Wed Oct 31 21:55:25 2012
> New Revision: 306768
> URL: http://svn.freebsd.org/changeset/ports/306768
>
> Log:
>   - fix process detection in Squid's rc.d script [1]
>   - remove a leftover substitution with a hard coded value
>   - remove a few comments which were accidentally left in from development
>   - rework the code that deals with kerberos negotiate auth a bit
>   - bump PORTREVISION for the squid rc.d script update
>
>   PR:           ports/173236 [1]  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=173236
>   PR:           ports/173248  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=173248
>   Submitted by: Thomas-Martin Seck <tmseck@web.de> (maintainer)
>   Reported by:  Leonid Nevecherya <nlv@imbera.ru> [1]
>   Feature safe: yes
>
> Modified:
>   head/www/squid32/Makefile
>   head/www/squid32/files/squid.in

I've made some minor style fixes to Squid's rc script, mostly making
sure the code is in the right order and using the less verbose style
for setting defaults to make it clearer that they're setting
themselves.

Thomas, is this patch OK?

http://www.bayofrum.net/~crees/patches/squid-style-fixes.diff

Chris