From owner-freebsd-current Tue Jun 13 7:59:37 2000 Delivered-To: freebsd-current@freebsd.org Received: from node1457.a2000.nl (node1457.a2000.nl [62.108.20.87]) by hub.freebsd.org (Postfix) with ESMTP id D31E737C0C5 for ; Tue, 13 Jun 2000 07:59:26 -0700 (PDT) (envelope-from freebsd@node1457.a2000.nl) Received: from localhost (freebsd@localhost) by node1457.a2000.nl (8.9.3/8.9.3) with SMTP id QAA08395 for ; Tue, 13 Jun 2000 16:59:30 +0200 Date: Tue, 13 Jun 2000 16:59:29 +0200 (MET DST) From: Bart Thate To: freebsd-current@freebsd.org Subject: current jail panic II Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi again ;) this patch .. http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/kern/uipc_socket.c.diff?r1=1.72&r2=1.73 makes my kernel panic. a snippet from gdb -k .. #10 0xc01705b5 in socreate (dom=28, aso=0xca35df20, type=2, proto=0, p=0xc9959be0) at ../../kern/uipc_socket.c:138 138 if (p->p_prison && jail_socket_unixiproute_only && (kgdb) list 133 if (proto) 134 prp = pffindproto(dom, proto, type); 135 else 136 prp = pffindtype(dom, type); 137 138 if (p->p_prison && jail_socket_unixiproute_only && 139 prp->pr_domain->dom_family != PF_LOCAL && 140 prp->pr_domain->dom_family != PF_INET && 141 prp->pr_domain->dom_family != PF_ROUTE) { 142 return (EPROTONOSUPPORT); (kgdb) print prp $1 = (struct protosw *) 0x0 prp is 0x0 but is not checked upon. The check if prp ==0 is done 2 lines further on. if (prp == 0 || prp->pr_usrreqs->pru_attach == 0) return (EPROTONOSUPPORT); since both if-s return EPROTONOSUPPORT the fix is to move the prp == 0 if in front of the patches lines. Should i send-pr this? Grtx, Bart To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message