From owner-svn-src-head@freebsd.org  Mon Sep 18 15:14:31 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 014BAE1727D;
 Mon, 18 Sep 2017 15:14:31 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C03936D23F;
 Mon, 18 Sep 2017 15:14:30 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id D63B0260105;
 Mon, 18 Sep 2017 17:14:28 +0200 (CEST)
Subject: Re: svn commit: r323692 - in head/sys/compat: linsysfs linux
To: Conrad Meyer <cem@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201709172340.v8HNeGuP016998@repo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <74fa25ac-685e-c3f8-90d6-cdfac10a0f88@selasky.org>
Date: Mon, 18 Sep 2017 17:12:01 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <201709172340.v8HNeGuP016998@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 15:14:31 -0000

On 09/18/17 01:40, Conrad Meyer wrote:
> +
> +		dinfo = device_get_ivars(parent);
> +		if (dinfo != NULL && dinfo->cfg.baseclass == PCIC_DISPLAY) {
> +			devclass = device_get_devclass(dev);
> +			if (devclass != NULL)
> +				name = devclass_get_name(devclass);
> +			if (name != NULL && strcmp(name, DRMN_DEV) == 0 &&
> +			    device_get_unit(dev) >= 0) {
> +				sprintf(chardevname, "226:%d",

Order of comparison should be switched.

First check devclass and name.

Then try to access ivars. Else the ivars might have an undefined type!

--HPS