From owner-freebsd-bugs  Thu Jan 18 22:03:06 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id WAA10910
          for bugs-outgoing; Thu, 18 Jan 1996 22:03:06 -0800 (PST)
Received: from ref.tfs.com (ref.tfs.com [140.145.254.251])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id WAA10904
          for <bugs@freebsd.org>; Thu, 18 Jan 1996 22:03:03 -0800 (PST)
Received: (from julian@localhost) by ref.tfs.com (8.6.12/8.6.9) id WAA06105; Thu, 18 Jan 1996 22:02:26 -0800
From: Julian Elischer <julian@ref.tfs.com>
Message-Id: <199601190602.WAA06105@ref.tfs.com>
Subject: Re: kern/951: DEVFS panic with SCSI tape (fix found!)
To: sysseh@devetir.qld.gov.au (Stephen Hocking)
Date: Thu, 18 Jan 1996 22:02:25 -0800 (PST)
Cc: bugs@freebsd.org
In-Reply-To: <199601190505.FAA23894@netfl15a.devetir.qld.gov.au> from "Stephen Hocking" at Jan 19, 96 03:05:05 pm
X-Mailer: ELM [version 2.4 PL24]
Content-Type: text
Sender: owner-bugs@freebsd.org
Precedence: bulk

HANG ON!
How can this be?
All it is doing is using sprintf on that buffer,
and all the occurances are about 8 characters long..
the buffer is 32 bytes long..
exactly WHAT names are appearing in the DEVFS?
it only puts the device name part into the string, not the full
path name..

eh?

yours confusedly

julian

> 
> I've found a fix for this - the DEVFS code was overrunning a buffer in st.c, 
> causing it to do strange & terrible things to other stuff on the stack. To 
> fix, change line 276 of /sys/scsi/st.c to be
> 
> 	static char name[128];
> 
> It all works now, can someone commit a change (and probably review the 
> buffersize for this stuff that DEVFS uses? I see some other errors (nothing 
> fatal) on another relating to the psm0 device abouth not being able to 
> allocate a name slot.)
> 
> 
> 	Stephen
> -- 
> 
>         I do not speak for the Worker's Compensation Board of Queensland -
>                      They don't pay me enough for that!
> 
> 
>