Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Nov 2021 03:24:47 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Yasuhiro Kimura <yasu@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo
Message-ID:  <YZR1/8m59hCb41l1@FreeBSD.org>
In-Reply-To: <202111170314.1AH3ETSV087319@gitrepo.freebsd.org>
References:  <202111170314.1AH3ETSV087319@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 17, 2021 at 03:14:29AM +0000, Yasuhiro Kimura wrote:
> commit bb8dbe1580ae0b500c3751c0fc1b681c65733cff
> 
>     sysutils/lnav: Fix distinfo
>     
>     Distinfo was wrongly updated to that of BETA1 release when this port
>     was updated to 0.10.1.
>     
>     While I'm here,
>     
>     * Switch to DISTVERSION
> @@ -1,7 +1,7 @@
>  # Created by: Thomas Hurst <tom@hur.st>
>  
>  PORTNAME=	lnav
> -PORTVERSION=	0.10.1
> +DISTVERSION=	0.10.1

I know you prefer DISTVERSION by default for some obscure reason, but
changing just the knob spelling without actual version number is what
we call gratuitous change and something we try to avoid as it clobbers
the history, thus pessimizing code archaeology process, and decreases
commit diff SNR.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YZR1/8m59hCb41l1>