From owner-freebsd-threads@FreeBSD.ORG  Tue Sep  7 09:46:20 2010
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8703E10656F0
	for <freebsd-threads@freebsd.org>; Tue,  7 Sep 2010 09:46:20 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 5B3258FC1A;
	Tue,  7 Sep 2010 09:46:20 +0000 (UTC)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o879kIor053434;
	Tue, 7 Sep 2010 09:46:19 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4C867A6B.8040408@freebsd.org>
Date: Tue, 07 Sep 2010 17:46:19 +0000
From: David Xu <davidxu@freebsd.org>
User-Agent: Thunderbird 2.0.0.24 (X11/20100630)
MIME-Version: 1.0
To: Kostik Belousov <kostikbel@gmail.com>
References: <20100906220041.GA4729@stack.nl> <4C86787E.6070908@freebsd.org>
	<20100907094249.GA2465@deviant.kiev.zoral.com.ua>
In-Reply-To: <20100907094249.GA2465@deviant.kiev.zoral.com.ua>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-threads@freebsd.org
Subject: Re: sigwait() cancellation point
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Sep 2010 09:46:20 -0000

Kostik Belousov wrote:
> On Tue, Sep 07, 2010 at 05:38:06PM +0000, David Xu wrote:
>> Jilles Tjoelker wrote:
>>> Our sigwait() implementation may not be POSIX-compliant as it returns
>>> EINTR when it is interrupted by a caught signal. (Unfortunately I can
>>> only find this in SUSv4 in the Rationale, B.2.3 Error Numbers,
>>> Disallowing Return of the [EINTR] Error Code; the sigwait() page in XSH
>>> does not list an [EINTR] error condition, but does not prohibit one
>>> either like pthread_mutex_lock() and various others do.)
>>>
>>> However, libthr's wrapper for sigwait() relies on EINTR. To keep
>>> the possibility of changing this to be what POSIX intends, it would be
>>> nice to remove this dependency.
>>>
>>> One way is to include SIGCANCEL in the set of waited signals, but this
>>> requires two additional syscalls to mask/unmask SIGCANCEL.
>>>
>>> Another way is to use sigwaitinfo() in the wrapper, which is permitted
>>> to return [EINTR]. If [EINTR] is removed from the kernel sigwait(),
>>> looping on [EINTR] can then be implemented in the wrapper.
>>>
>>> Calling pthread_exit from the SIGCANCEL handler is not possible as this
>>> leaves the program in doubt about any signal consumed by sigwait().
>>>
>> I have worked out a patch:
>>
>> http://people.freebsd.org/~davidxu/patch/sigwait.diff
> Isn't __sys_sigwait() supposed to return -1 and set errno ?
No, it returns error code, and zero means success.