From owner-svn-src-head@freebsd.org Fri Dec 14 03:30:02 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36A1E130CF7B for ; Fri, 14 Dec 2018 03:30:02 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-it1-x130.google.com (mail-it1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BDD1188349 for ; Fri, 14 Dec 2018 03:30:01 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by mail-it1-x130.google.com with SMTP id i145so7039853ita.4 for ; Thu, 13 Dec 2018 19:30:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YvB3iCKfzsRo29xoyUN+pcGywxzI3xMUgq8vlfwS+vU=; b=oycWiqNQiAeaL8O6sPAEeQJTSJaoM3pPr535ihfEGeHgH7RuJUepU2QEIoGxgzt6/z Y1ky54IkQbVHMtZewMN0jpqdKB814TfDWVK7c14+me5igewX88mUEK398ztWg0lYcpMm qM9XoYYXB7JfFwsVZsyQ7v5JLf7C+6IPqcsgg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YvB3iCKfzsRo29xoyUN+pcGywxzI3xMUgq8vlfwS+vU=; b=qg777MQjsGN+VaHIZldjWnZR8ndiLABs/RL9A2M+nR6+X+ppfqw27r0wPHCkzI5ICF YQ+zILaSZEf9qnnKAp0aYj5ZhdZOeWj/u+X7QIUtNE0iDPpQVXbYwKj6bQJClWKWqIpP WEde3ew7XtIweHzWbsNbY6a5YFqzlw0vdBSDd1bFkYosWQ0OM8SJcNYUQuUUR5h/0sWX pS0km68oUKSHzzt60nf9h8/JQU1q++rjl4s0UC20sZ5ZSdWRCqcXpy+EAfdZkgqVFl3z ZuEEXBScAX5ivPciFQRlFyXduokXFXSWal4bbL5E1pgve0j/XGx5CsuPWwNZ3P/i8wqr n9mA== X-Gm-Message-State: AA+aEWbfZUUiSvjdGhaM3VyV54ad6V0JH7JvNkaQdPqPx9UnM7Kn4Hz/ aRudKGR2RmOu65FkFHL0a52QP0yZJxoSq4h8RNTkFg== X-Google-Smtp-Source: AFSGD/VD71d+NHycgCegKm6in6mgIC0A3+RXuQvUVKX+lmg5iPDLdZtza/uVTQUwTEo79ZF32rrv/b8qxrKL4ffanX0= X-Received: by 2002:a24:b50a:: with SMTP id v10mr1925271ite.21.1544758201105; Thu, 13 Dec 2018 19:30:01 -0800 (PST) MIME-Version: 1.0 References: <201812140106.wBE16Zgr058499@repo.freebsd.org> <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> In-Reply-To: <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> From: Kevin Bowling Date: Thu, 13 Dec 2018 20:29:50 -0700 Message-ID: Subject: Re: svn commit: r342057 - head/crypto/openssl/crypto/engine To: koobs@freebsd.org Cc: Jung-uk Kim , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: BDD1188349 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-5.87 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_SHORT(-0.88)[-0.877,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 03:30:02 -0000 But why, you can trivially see the open() call with truss or more advanced tracers if you are debugging this On Thu, Dec 13, 2018 at 6:39 PM Kubilay Kocak wrote: > On 14/12/2018 12:06 pm, Jung-uk Kim wrote: > > Author: jkim > > Date: Fri Dec 14 01:06:34 2018 > > New Revision: 342057 > > URL: https://svnweb.freebsd.org/changeset/base/342057 > > > > Log: > > Do not complain when /dev/crypto does not exist. > > > > Now the new devcrypto engine is enabled since r342009, many users > started > > seeing "Could not open /dev/crypto: No such file or directory". > Disable > > the annoying error message as it is not very useful anyway. > > > > Note the patch was submitted upstream. > > > > https://github.com/openssl/openssl/pull/7896 > > > > Modified: > > head/crypto/openssl/crypto/engine/eng_devcrypto.c > > > > Modified: head/crypto/openssl/crypto/engine/eng_devcrypto.c > > > ============================================================================== > > --- head/crypto/openssl/crypto/engine/eng_devcrypto.c Fri Dec 14 > 00:40:38 2018 (r342056) > > +++ head/crypto/openssl/crypto/engine/eng_devcrypto.c Fri Dec 14 > 01:06:34 2018 (r342057) > > @@ -24,6 +24,8 @@ > > > > #include "internal/engine.h" > > > > +/* #define ENGINE_DEVCRYPTO_DEBUG */ > > + > > #ifdef CRYPTO_ALGORITHM_MIN > > # define CHECK_BSD_STYLE_MACROS > > #endif > > @@ -615,6 +617,9 @@ void engine_load_devcrypto_int() > > ENGINE *e = NULL; > > > > if ((cfd = open("/dev/crypto", O_RDWR, 0)) < 0) { > > +#ifndef ENGINE_DEVCRYPTO_DEBUG > > + if (errno != ENOENT) > > +#endif > > fprintf(stderr, "Could not open /dev/crypto: %s\n", > strerror(errno)); > > return; > > } > > How trivially could devcrypto_debug be modified to be a runtime > configuration (say sysctl) setting? > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >