From owner-freebsd-ports Fri Aug 16 17:50: 9 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E46A337B400 for ; Fri, 16 Aug 2002 17:50:03 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62A4343E3B for ; Fri, 16 Aug 2002 17:50:03 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7H0o2JU006091 for ; Fri, 16 Aug 2002 17:50:02 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7H0o2MW006090; Fri, 16 Aug 2002 17:50:02 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F3EC37B400 for ; Fri, 16 Aug 2002 17:40:32 -0700 (PDT) Received: from squigy.ddm.wox.org (p5b.neon.sentex.ca [64.7.130.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45FE543E6A for ; Fri, 16 Aug 2002 17:40:29 -0700 (PDT) (envelope-from dchapes@ddm.wox.org) Received: from rama.ddm.wox.org (rama.ddm.wox.org [204.50.152.20]) by squigy.ddm.wox.org (Postfix) with ESMTP id 9640D8B802; Fri, 16 Aug 2002 20:40:27 -0400 (EDT) Received: by rama.ddm.wox.org (Postfix, from userid 5000) id 29C2272DE0; Fri, 16 Aug 2002 20:40:25 -0400 (EDT) Message-Id: <20020817004024.GA43808@ddm.wox.org> Date: Fri, 16 Aug 2002 20:40:24 -0400 From: Dave Chapeskie Reply-To: Dave Chapeskie To: FreeBSD-gnats-submit@FreeBSD.org Cc: girgen@partitur.se X-Send-Pr-Version: 3.113 Subject: ports/41739: postgresql-odbc change request [PATCH] Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 41739 >Category: ports >Synopsis: postgresql-odbc support for unixodbc [PATCH] >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Aug 16 17:50:01 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Dave Chapeskie >Release: FreeBSD 4.5-STABLE i386 >Organization: DDM Consulting >Environment: System: FreeBSD rama.ddm.wox.org 4.5-STABLE FreeBSD 4.5-STABLE #0: Sat Mar 2 16:42:36 EST 2002 dchapes@rama.ddm.wox.org:/stripe0/usr/obj/stripe0/usr/src/sys/RAMA i386 >Description: I have need of the unixodbc version of the PostgreSQL odbc drivers and need to have other packages depend on it. Thus I not only need the compilation option provided in the port makefile via the DRIVER_MANAGER variable but I also need the name of the produced package to be different from the normal one. The standard way of indicating compilation options in package names is by the use of PKGNAMESUFFIX. I've attached a patch which does this. It's done so that the current default package name doesn't change. Using -iodbc instead of the current -odbc would probably be better but that would entail changing the current default package name and breaking existing dependencies. >How-To-Repeat: >Fix: Index: Makefile =================================================================== RCS file: /cvs/ports/databases/postgresql-odbc/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- Makefile 11 Apr 2002 05:08:34 -0000 1.2 +++ Makefile 15 Aug 2002 20:53:07 -0000 @@ -5,7 +5,7 @@ # $FreeBSD: ports/databases/postgresql-odbc/Makefile,v 1.2 2002/04/11 05:08:34 ijliao Exp $ # -PORTNAME= postgresql-odbc +PORTNAME= postgresql CATEGORIES= databases MAINTAINER= girgen@partitur.se @@ -30,10 +30,12 @@ # folks say their is the best, so you might be better off removing # the others? .if ${DRIVER_MANAGER} == "unixodbc" +PKGNAMESUFFIX= -unixodbc CONFIGURE_ARGS+= --with-unixodbc LIB_DEPENDS+= odbc.1:${PORTSDIR}/databases/unixODBC PLIST_SUB+=UNIXODBC="" IODBC="@comment " .else # assume we're using iodbc +PKGNAMESUFFIX= -odbc LIB_DEPENDS+= iodbc.3:${PORTSDIR}/databases/libiodbc CONFIGURE_ARGS+= --with-iodbc --with-odbcinst=${LOCALBASE}/etc/libiodbc PLIST_SUB+=UNIXODBC="@comment " IODBC="" >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message