From owner-cvs-all@FreeBSD.ORG Sat Jan 7 05:18:05 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9EB6316A41F; Sat, 7 Jan 2006 05:18:05 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 075B043D45; Sat, 7 Jan 2006 05:18:02 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k075I1gk097187; Fri, 6 Jan 2006 22:18:01 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <43BF4F11.9000103@samsco.org> Date: Fri, 06 Jan 2006 22:18:09 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20051230 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200601061630.k06GUUXW022868@repoman.freebsd.org> <43BE9C19.6070600@samsco.org> <200601061253.51551.jhb@freebsd.org> In-Reply-To: <200601061253.51551.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2006 05:18:05 -0000 John Baldwin wrote: > On Friday 06 January 2006 11:34 am, Scott Long wrote: > >>John Baldwin wrote: >> >>>jhb 2006-01-06 16:30:30 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern kern_descrip.c >>> Log: >>> Return EBADF rather than EINVAL for FWRITE failure as per POSIX. >>> >>> MFC after: 1 week >>> >>> Revision Changes Path >>> 1.290 +2 -3 src/sys/kern/kern_descrip.c >> >>Technically this will be an API change if it get's MFC'd, though a >>minor one. If it needs to go into RELENG_6 then it should be >>clearly documented in the release notes. > > > Not really because except for the hwpmc(4) driver and the mqueue code (which > isn't in 6.x yet IIRC), every other caller of fget_write() ignores the errno > value and hardcodes EBADF, so it won't actually change the errno for any > applications in 6.x. > While it may not be used by much in the FreeBSD tree, the fact that fget_write() is available via a kernel header means that it is part of the kernel API. It is trivial, so all I ask is that it be well documented when it gets MFC'd. Something along the lines of: - fget_write() was changed to provide return values as per POSIX. Scott