From owner-svn-src-all@freebsd.org Wed Jun 1 20:22:23 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49C04B61533; Wed, 1 Jun 2016 20:22:23 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 2D9DE131C; Wed, 1 Jun 2016 20:22:23 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id CBDE713BA; Wed, 1 Jun 2016 20:22:22 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Wed, 1 Jun 2016 20:22:21 +0000 From: Glen Barber To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301163 - in head: etc libexec/dma/dmagent Message-ID: <20160601202221.GP75780@FreeBSD.org> References: <201606012006.u51K6t0d012285@repo.freebsd.org> <0933c625-d329-6c4c-88ba-093ad955d475@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="A6Z7MKnLVMfR85kG" Content-Disposition: inline In-Reply-To: <0933c625-d329-6c4c-88ba-093ad955d475@FreeBSD.org> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 20:22:23 -0000 --A6Z7MKnLVMfR85kG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 01, 2016 at 01:13:20PM -0700, Bryan Drewery wrote: > On 6/1/16 1:06 PM, Glen Barber wrote: > > Author: gjb > > Date: Wed Jun 1 20:06:55 2016 > > New Revision: 301163 > > URL: https://svnweb.freebsd.org/changeset/base/301163 > >=20 > > Log: > > Implement a hack to re-enable installation of the dma.conf. > > =20 > > The 'CONFS' entries in share/mk/bsd.confs.mk explicitly check > > for the 'installconfig', but does not behave properly with the > > 'distribute' target. > > =20 >=20 > This just moves something out of installconfig, leaving it apparently > still broken. >=20 > Please revert this and r301137 and lets fix this properly. I'm pretty > surprised by this. >=20 I'm happy to revert these two commits, they were never intended to be a permanent fix (I probably should have noted that in the commit log). I'm still wrapping my head around what share/mk/bsd.confs.mk is trying to do, and why it is interfering with installing these files. Before these are reverted, do you have an idea in mind of a proper fix? Glen --A6Z7MKnLVMfR85kG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXT0P9AAoJEAMUWKVHj+KTCJsP/1Nxtx+/uXD7T3GCB72Pducp Z65hHRvfEaxK0y69AMyXw0+AEchV6MJEqHxC2sKvoNClrgKCrISphDvgaduXxrj+ usqcYGSxLSJWqo06nsQ3Rkemyg/dn03wclITT3Z3BzouoerjuO8LlJaxVp7d/Qd7 K4a1mzs16Y45f3fC1eJGvuOOkQ+ah7UGjVUXNlE/3WWXIFrOd7TwKI9sAz7apnIC oJ6OTSb9gE3/j9HUmUTn6x2A1XVVyfE+unPg6DdKALLhaAlcQjulG1GVphglOJj/ W8pQvOcY0Rn/DPxp2tfrkW0YH5GYPg2w7Zh/+gxkhPRfMXFiNm6bUk+3u63aob4r SIyMWAmYO1qmY7CztFO69Msp8xm1HHOHNqO72/HIw8j/sUxB03PUOw9Puubu0G+a suFG3c3Y82UiGuEJ+i22JqvAQ7VTqcu1GFIcPwM+YQWzj1B1y/3sOkacgCqVhmM/ BMFvVbaWCA/NtMSUkY5sibueoAviTga+44mTCMg3w/2pCh8hDIzEwz31yJAx3muX 6lKl8+HIk1nH2ERW9M6yx4q/4Fe1lZOrYlKyvDToxBvM+ETdOZ7g/2rUisSK8in2 CLx9TXUC/YVnvGWMufW3D9ilIcWWFPyej3NV35uKw8kDcBT14sJuYaz5U2b5r+MZ 97LCn4ZbfJt5E1G1lh3l =eYVd -----END PGP SIGNATURE----- --A6Z7MKnLVMfR85kG--