Date: Sun, 30 Dec 2018 16:17:14 +0100 From: Tobias Kortkamp <tobik@freebsd.org> To: Adriaan de Groot <adridg@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r488719 - in head: sysutils/kf5-kwallet www/falkon x11/plasma5-plasma Message-ID: <20181230151713.GA78574@urd.tobik.me> In-Reply-To: <201812301415.wBUEFsZU000750@repo.freebsd.org> References: <201812301415.wBUEFsZU000750@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 30, 2018 at 02:15:54PM +0000, Adriaan de Groot wrote: > Author: adridg > Date: Sun Dec 30 14:15:54 2018 > New Revision: 488719 > URL: https://svnweb.freebsd.org/changeset/ports/488719 >=20 > Log: > Add OPTIONS to some kde@ ports. > =20 > For best runtime performance (e.g. a fully functional desktop), users w= ill > need a pinentry application -- pinentry-qt fits best into the KDE deskt= op, > but it could be a different one -- and sound output. Pick a default bac= kend > and some OSS plugins to make that happen. > =20 > These are OPTIONS so the users interested in a minimal desktop or one w= ith > different audio needs can build suitable packages themselves. > =20 > Reviewed by: tcberner > Differential Revision: https://reviews.freebsd.org/D18680 >=20 > Modified: > head/sysutils/kf5-kwallet/Makefile > head/www/falkon/Makefile > head/x11/plasma5-plasma/Makefile >=20 > Modified: head/www/falkon/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/www/falkon/Makefile Sun Dec 30 14:05:27 2018 (r488718) > +++ head/www/falkon/Makefile Sun Dec 30 14:15:54 2018 (r488719) > @@ -2,7 +2,7 @@ > =20 > PORTNAME=3D falkon > DISTVERSION=3D 3.0.0 > -PORTREVISION=3D 2 > +PORTREVISION=3D 3 > CATEGORIES=3D www > MASTER_SITES=3D KDE/stable/falkon/${DISTVERSION:R}/src/ > =20 > @@ -21,11 +21,16 @@ USE_XORG=3D xcb > =20 > USE_LDCONFIG=3D yes > =20 > -OPTIONS_DEFINE=3D GNOMEKEYRING > +OPTIONS_DEFINE=3D GNOMEKEYRING ALSA > +OPTIONS_DEFAULT=3D ALSA > OPTIONS_SUB=3D YES > =20 > GNOMEKEYRING_CMAKE_BOOL=3D BUILD_KEYRING > GNOMEKEYRING_USE=3D GNOME=3Dglib20 > GNOMEKEYRING_LIB_DEPENDS=3D libgnome-keyring.so:security/libgnome-keyring > + > +# Need the plugins to get sound, otherwise messages that the > +# pcm_oss plugin can't be opened. > +ALSA_RUN_DEPENDS=3D alsa-plugins>=3D0:audio/alsa-plugins This seems really backwards to me. Would it not make more sense to add the ALSA plugins bit to qt5-webengine? It is after all qt5-webengine that outputs sound not Falkon itself. What about all the other browsers based on qt5-webengine (otter-browser, konqueror, qutebrowser, ...)? --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAlwo4XRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2HUeQf9GyRHmvgyhRkxWQ/jOAtHpScCvXsAByGjuv+IJPMGS6NKDsZn74/gxWio /NIqr5LDCZyK3krT9Mjv3fwSevI7RuqrM4GHPp+0D6mafIyH9+/ystF5J85bl9rN vRA3xMFBEWuwGE7eM27FJZoCkW5Ota3EgU5eGjS44tTRlDO3aA5FAl5wbVnGVKq0 Ft2UzH7cJUCeIEy+AUpZooLcgqiWwfGLY4GDDopMAgjEi4YiMNjYgI0GOJKPW0ZO WvK/sez2V1AmwAwUpGsWzueAauIjPqP0QWwaeohQUriE5BGGfOcN8Ssmtl218Z23 ZJFi+euc6mK2NyevqAGbbb+BWvwEjg== =AIYR -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181230151713.GA78574>