Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Sep 2018 14:15:29 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r479024 - head/multimedia/libx264
Message-ID:  <201809051415.w85EFTY6058445@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste (src committer)
Date: Wed Sep  5 14:15:28 2018
New Revision: 479024
URL: https://svnweb.freebsd.org/changeset/ports/479024

Log:
  multimedia/libx264: set LLD_UNSAFE for i386 and armv7
  
  libx264 has relocations against readonly segment(s) and lld exits with
  an error suggesting recompiling with -fPIC.  As this may introduce a
  performance impact, for now just fall back to GNU ld.bfd.
  
  PR:		230214
  Approved by:	koobs (maintainer)
  MFH:		2018Q3

Modified:
  head/multimedia/libx264/Makefile

Modified: head/multimedia/libx264/Makefile
==============================================================================
--- head/multimedia/libx264/Makefile	Wed Sep  5 14:07:19 2018	(r479023)
+++ head/multimedia/libx264/Makefile	Wed Sep  5 14:15:28 2018	(r479024)
@@ -13,6 +13,10 @@ PLIST=		${.CURDIR}/pkg-plist
 LIB_DEPENDS=	#
 
 USES=		pathfix
+.if ${ARCH} == "i386" || ${ARCH} == "armv7"
+# PR230214 port has relocations against read-only segment (.text)
+LLD_UNSAFE=	yes
+.endif
 
 OPTIONS_DEFINE=		ASM OPENCL
 OPTIONS_DEFAULT=	ASM OPENCL



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809051415.w85EFTY6058445>