From owner-freebsd-mobile Fri Dec 10 13:18: 4 1999 Delivered-To: freebsd-mobile@freebsd.org Received: from pulsar.dead-end.net (pulsar.high-performance.com [216.15.153.82]) by hub.freebsd.org (Postfix) with ESMTP id 743C414BE3 for ; Fri, 10 Dec 1999 13:17:53 -0800 (PST) (envelope-from rock@dead-end.net) Received: from mailto.dead-end.net (dead-end.net [216.15.153.82] (may be forged)) by pulsar.dead-end.net (8.9.3/8.9.3/DEAD-END/1999020900) with ESMTP id WAA74575; Fri, 10 Dec 1999 22:17:46 +0100 (CET) (envelope-from rock@dead-end.net) Received: from server.rock.net (pC19F74EB.dip.t-dialin.net [193.159.116.235]) by mailto.dead-end.net (8.9.3/DEAD-END/1999102400-Customer) with ESMTP id WAA74571; Fri, 10 Dec 1999 22:17:45 +0100 (CET) (envelope-from rock@dead-end.net) Received: from dead-end.net (solaris.rock.net [172.23.7.10]) by server.rock.net (8.9.3/8.9.3) with ESMTP id WAA91602; Fri, 10 Dec 1999 22:00:31 +0100 (CET) (envelope-from rock@dead-end.net) Message-ID: <385169FE.97592A18@dead-end.net> Date: Fri, 10 Dec 1999 22:00:46 +0100 From: "D. Rock" X-Mailer: Mozilla 4.7 [en] (X11; I; SunOS 5.7 i86pc) X-Accept-Language: de, en MIME-Version: 1.0 To: Warner Losh Cc: mobile@FreeBSD.ORG Subject: Re: ed fix committed References: <199912100730.AAA20281@harmony.village.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Warner Losh wrote: > > OK. I've committed a fix for the ed driver. The basic problem was > that it didn't properly release the interrupt, so the interrupt was > still getting called, which lead to all kinds of problems. > > I've also improved how old pccard does the interrupt allocation. It > now does its work when the interrupt is setup rather than when the irq > is activated. Likewise with deactivate and teardown_intr. > > This seems to work now, and does't seem to break ep. > > I've not tried sio, but suspect it will be no more broken than it > currently seems to be. > > One extra '&' took two and a half hours to find. This is why I don't > want to keep maintaing the old code as I was unable to put those hours > into new card.... Looks really good. I tested it (insert/remove into different slots) and found only a minor glitch with suspend/resume: Suspension always seems to produces a "stray irq XX" and if I switch slots for a card after suspensions, it won't be detected after resume (sio OTOH was detected). Instead pccardd reports: pccardd[40]: No free configuration for card D-Link This is really no big deal. I can work with that. Daniel To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message