Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Jun 2015 16:47:15 -0400
From:      Allan Jude <allanjude@freebsd.org>
To:        Garrett Cooper <yaneurabeya@gmail.com>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r284644 - head/usr.sbin/fstyp
Message-ID:  <5585D153.9020508@freebsd.org>
In-Reply-To: <A4E24B22-B2C8-4846-BE94-6D0A31E448E6@gmail.com>
References:  <201506201503.t5KF33Km091795@svn.freebsd.org> <A4E24B22-B2C8-4846-BE94-6D0A31E448E6@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--PeSXSMQePM2gORHcGjlJDEp1t97PxbNuX
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 2015-06-20 16:16, Garrett Cooper wrote:
>=20
>> On Jun 20, 2015, at 08:03, Allan Jude <allanjude@FreeBSD.org> wrote:
>>
>> Author: allanjude (doc committer)
>> Date: Sat Jun 20 15:03:02 2015
>> New Revision: 284644
>> URL: https://svnweb.freebsd.org/changeset/base/284644
>>
>> Log:
>>  Fix the build for gcc by lowering the WARNS level
>>
>>  Approved by:    sbruno
>>  X-MFC-With:    r284589
>>
>> Modified:
>>  head/usr.sbin/fstyp/Makefile
>>
>> Modified: head/usr.sbin/fstyp/Makefile
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/usr.sbin/fstyp/Makefile    Sat Jun 20 13:30:09 2015    (r2846=
43)
>> +++ head/usr.sbin/fstyp/Makefile    Sat Jun 20 15:03:02 2015    (r2846=
44)
>> @@ -11,7 +11,7 @@ SRCS +=3D    zfs.c
>>
>> MAN=3D    fstyp.8
>>
>> -WARNS=3D    6
>> +WARNS?=3D    0
>=20
> You could also guard it by COMPILER_TYPE. As others have stated though,=
 fixing the prototypes issues is relatively trivial...
>=20

This set of changes [1] allows WARNS=3D5, but 6 still has some outstandin=
g
issues [2]


[1]
https://github.com/illumos/illumos-gate/compare/master...allanjude:fix_gc=
c_warnings?expand=3D1
[2] https://reviews.freebsd.org/D2045#55692

--=20
Allan Jude


--PeSXSMQePM2gORHcGjlJDEp1t97PxbNuX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQIcBAEBAgAGBQJVhdFZAAoJEBmVNT4SmAt+058P/RF/rBQWd40aBKlIBNPUImll
Dtu6MNm8tbWwQ8d06oelXnjhWWJOGO11LP8BoL5iOWy1LZQDS+IIGU1+nNud32YB
nw3yJ8emX6ZBXIL3d1xFKU9LOS84aN7ma2XZKtvzmCQtVY+qAVzYijUW+CBa/QTB
nMy8lHYIrTHm66HsQKEyxvkUbFOQTHq6BXJyQBVKX9V3LVApje/lOWXd05XH6RwU
M2sVcP/TzGwiYRqLoBAIahI5tpbHrGeIYBrfNl0rEMwsDGr7oUbuV69Wb36EAfYC
7MuNX35c9KuhC8OUxjDvvPhSKeDSIqU5QCPXenAm7CNMo4mTtaG8DI17g0UhBbWZ
kcKQ+iy5XvxTY/YW0L4pDTuiq4R+d1tMF47Bb5IdItJWFiUkQnFJxaxE6lKw76N5
bcPk4NFjsUOTO/rKvmU+BNB42DJvL5px6JNWVuHmZxKIN6osmRGWRuNHaojr/CCK
d8E+OeSl/gCy3O23J483S95L/lzcYGCMJUxNlmkTmQPJeb0OUxC28+Se3selSFlf
Ex+CA64IvzUoHWxBMbeoRKkQhlDBEQXzmMAGw3nUXyukJKHUmuL4LGkfDx7kd8id
SUH9glIyJe2Hc4cguXItzDwO4aPm2x0CevC6E/OrXxN+Awkd32lgJqqttQDn9jqa
abeKt+w5In0yOyit9mWB
=o9sb
-----END PGP SIGNATURE-----

--PeSXSMQePM2gORHcGjlJDEp1t97PxbNuX--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5585D153.9020508>