From owner-cvs-sys Tue Nov 19 10:47:30 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id KAA23654 for cvs-sys-outgoing; Tue, 19 Nov 1996 10:47:30 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id KAA23645; Tue, 19 Nov 1996 10:47:24 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id FAA08561; Wed, 20 Nov 1996 05:38:07 +1100 Date: Wed, 20 Nov 1996 05:38:07 +1100 From: Bruce Evans Message-Id: <199611191838.FAA08561@godzilla.zeta.org.au> To: bde@zeta.org.au, nate@mt.sri.com Subject: Re: cvs commit: src/sys/i386/isa syscons.c Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, nate@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> > Found by: remote GDB >> >> I have been running with this change for some time. If userconfig is >> actually used, then the keyboard is unusable. > >Before this change, yes I agree. If sc_port isn't initialized it tries >to read the data from port 0, which doesn't have any keyboard >attached. :) > >The code is now almost exactly the same as the previous syscons 'getc' >code, except for some busy waits and such. > >> Apparently a scancode >> left over from quitting userconfig is interpreted as the keyboard >> command byte. > >Huh? What context are we talking about here? We're talking about bugs in the new keyboard code. See my reply to your report about userconfig being broken. It said that the bug was that sc_port wasn't initialized and then discussed at length the problems in the new keyboard code that I noticed while finding the bug. Of course I fixed the bug here. Bruce