From owner-svn-src-all@FreeBSD.ORG Fri Oct 25 14:21:19 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 84764FE6 for ; Fri, 25 Oct 2013 14:21:19 +0000 (UTC) (envelope-from tim@kientzle.com) Received: from mail-pb0-f42.google.com (mail-pb0-f42.google.com [209.85.160.42]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5A97C2A32 for ; Fri, 25 Oct 2013 14:21:19 +0000 (UTC) Received: by mail-pb0-f42.google.com with SMTP id jt11so3546664pbb.29 for ; Fri, 25 Oct 2013 07:21:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=TJ0jFUw06qj8LgGq4IssPjnn3lcO890qwLSwSNH43B8=; b=mUCoO+dRPhEfAJNk6AzmYQA3vVaQqbrOu3O9Nnt8+jrtXGZLKctdXSqKtizD/G3Pow 4uDrap6zC9grnU5eIaVhMh/QHU8bteknBLObUuGxEnjkFWnFbolg5UiJhuGHZYYTtbwq 6YhagJJM479GbR+NXhesUa5vY5JonMu6+7/y4BNkPg41vmbffGZ0AjvIvOKVo4I5MtxP LEA2jw5x3Kg93iKiDY9rSLMRVl6ZbBLpZd2+q7tvZ8/K5CD3uduxvz4WyU0SZnI/TrdX 6TcgDUrnfqbW+YMVIr7Wma18+VJqwWAuAUA46JCOX9Vh4JXUYjz/xuYYhgsRYQ91vEo8 BjLA== X-Gm-Message-State: ALoCoQkAz8Ghj/X2wD/bKfeJgVtxKqk9vILXuvl4KWgSgPQrtTVj4G5sKad3rN2vdxjpQCFj65Hj X-Received: by 10.66.66.42 with SMTP id c10mr10901988pat.98.1382710873026; Fri, 25 Oct 2013 07:21:13 -0700 (PDT) Received: from [192.168.43.193] ([172.56.31.101]) by mx.google.com with ESMTPSA id be1sm9870997pbb.28.2013.10.25.07.21.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 25 Oct 2013 07:21:12 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: svn commit: r257109 - head/contrib/llvm/tools/clang/tools/driver From: Tim Kientzle In-Reply-To: Date: Fri, 25 Oct 2013 07:20:57 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <1EFCA941-2972-40CD-8724-C16F8A0544CE@kientzle.com> References: <201310250909.r9P990nk083926@svn.freebsd.org> To: Dimitry Andric X-Mailer: Apple Mail (2.1510) Cc: svn-src-head@FreeBSD.org, Steven Hartland , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Oct 2013 14:21:19 -0000 On Oct 25, 2013, at 2:34 AM, Dimitry Andric wrote: > On 25 Oct 2013, at 11:09, Steven Hartland wrote: >> Author: smh >> Date: Fri Oct 25 09:09:00 2013 >> New Revision: 257109 >> URL: http://svnweb.freebsd.org/changeset/base/257109 >>=20 >> Log: >> Add clang-CC and CC to list of hints allowing clang to identify its = operating >> mode as c++ instead of defaulting to c for the binary names CC and = clang-CC. >>=20 >> This fixes builds that use cmake, which automatically sets CXX to >> /usr/bin/CC by default. >=20 > Huh, I=92ve never seen that behavior with cmake? At least, not with = any > fairly recent version...=20 >=20 > Anyway, I do not really agree with this change, and I would rather = just > get rid of the /usr/bin/CC link instead. Even if FreeBSD removes the default symlink, clang should still default to C++ mode when invoked as CC (possibly through a symlink created by an individual user). > Build scripts and Makefiles > should use "c++" instead, which is the standard name for a C++ = compiler. Ours should, yes. Tim