From owner-cvs-src-old@FreeBSD.ORG  Tue Feb  1 13:32:55 2011
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E1FE6106566C
	for <cvs-src-old@freebsd.org>; Tue,  1 Feb 2011 13:32:55 +0000 (UTC)
	(envelope-from lstewart@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id CF2C38FC1F
	for <cvs-src-old@freebsd.org>; Tue,  1 Feb 2011 13:32:55 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p11DWtuO001989
	for <cvs-src-old@freebsd.org>; Tue, 1 Feb 2011 13:32:55 GMT
	(envelope-from lstewart@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p11DWtKn001988
	for cvs-src-old@freebsd.org; Tue, 1 Feb 2011 13:32:55 GMT
	(envelope-from lstewart@repoman.freebsd.org)
Message-Id: <201102011332.p11DWtKn001988@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	lstewart@repoman.freebsd.org using -f
From: Lawrence Stewart <lstewart@FreeBSD.org>
Date: Tue, 1 Feb 2011 13:32:27 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/netinet cc.h src/sys/netinet/cc cc_newreno.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Feb 2011 13:32:56 -0000

lstewart    2011-02-01 13:32:27 UTC

  FreeBSD src repository

  Modified files:
    sys/netinet          cc.h 
    sys/netinet/cc       cc_newreno.c 
  Log:
  SVN rev 218167 on 2011-02-01 13:32:27Z by lstewart
  
  Algorithm modules can define their own private congestion signal types in the
  top 8 bits of the 32 bit signal bit field space for internal use. These private
  signals should not be leaked outside of a module.
  
  Given that many algorithm modules use the NewReno hook functions to simplify
  their implementation, the obvious place such a leak would show up is in the
  NewReno cong_signal hook function.
  
  - Show the full number of significant bits in the signal type definitions in
    <netinet/cc.h>.
  
  - Add a bitmask to simplify figuring out if a given signal is in the private or
    public bit range.
  
  - Add a sanity check in newreno_cong_signal() to ensure private signals are not
    being leaked into the hook function.
  
  Sponsored by:   FreeBSD Foundation
  Discussed with: David Hayes <dahayes at swin edu au>
  MFC after:      1 week
  X-MFC with:     r215166
  
  Revision  Changes    Path
  1.4       +6 -4      src/sys/netinet/cc.h
  1.4       +4 -0      src/sys/netinet/cc/cc_newreno.c