From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Jan  7 06:10:11 2012
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1FBEE106564A
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat,  7 Jan 2012 06:10:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D75928FC16
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat,  7 Jan 2012 06:10:10 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q076AAQH005715
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sat, 7 Jan 2012 06:10:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q076AAms005714;
	Sat, 7 Jan 2012 06:10:10 GMT (envelope-from gnats)
Resent-Date: Sat, 7 Jan 2012 06:10:10 GMT
Resent-Message-Id: <201201070610.q076AAms005714@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yury <yury@gorodok.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8316E106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat,  7 Jan 2012 06:01:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 71F218FC17
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat,  7 Jan 2012 06:01:47 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0761kvh024835
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 7 Jan 2012 06:01:46 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0761kjE024834;
	Sat, 7 Jan 2012 06:01:46 GMT (envelope-from nobody)
Message-Id: <201201070601.q0761kjE024834@red.freebsd.org>
Date: Sat, 7 Jan 2012 06:01:46 GMT
From: Yury <yury@gorodok.net>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: ports/163882: portupgrade of unrar-iconv has wrong patch
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Jan 2012 06:10:11 -0000


>Number:         163882
>Category:       ports
>Synopsis:       portupgrade of unrar-iconv has wrong patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 07 06:10:10 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Yury
>Release:        FreeBSD 8.2-R
>Organization:
>Environment:
FreeBSD  8.2-RELEASE-p5 FreeBSD 8.2-RELEASE-p5 #0: Fri Dec 30 14:14:35 NOVT 2011     yury@:/usr/obj/usr/src/sys/GJA822N  amd64
>Description:
Upgrading 'unrar-iconv-4.00,5' to 'unrar-iconv-4.10,5' failed due to
error applying patch file to strfn.cpp.
There are these strings in original
#ifdef _WIN_ALL
but patch assumes that they are
#if defined(_WIN_ALL)
>How-To-Repeat:
Try to portupgrade from 'unrar-iconv-4.00,5' to 'unrar-iconv-4.10,5'
>Fix:
substitute '#ifdef _WIN_ALL' for '#if defined(_WIN_ALL)' in files/patch-iconv (two places, that concern strfn.cpp)

>Release-Note:
>Audit-Trail:
>Unformatted: