From owner-svn-src-all@FreeBSD.ORG  Mon Jan 21 08:49:37 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id F4209E08;
 Mon, 21 Jan 2013 08:49:36 +0000 (UTC)
 (envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
 by mx1.freebsd.org (Postfix) with ESMTP id B1C358A5;
 Mon, 21 Jan 2013 08:49:35 +0000 (UTC)
Received: from localhost (unknown [86.188.145.194])
 by mail.dawidek.net (Postfix) with ESMTPSA id 433F44AF;
 Mon, 21 Jan 2013 09:46:56 +0100 (CET)
Date: Mon, 21 Jan 2013 09:49:55 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Andrey Zonov <zont@FreeBSD.org>
Subject: Re: svn commit: r245696 - head/usr.sbin/inetd
Message-ID: <20130121084936.GC1404@garage.freebsd.pl>
References: <201301201944.r0KJiY0C094120@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="+JUInw4efm7IfTNU"
Content-Disposition: inline
In-Reply-To: <201301201944.r0KJiY0C094120@svn.freebsd.org>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jan 2013 08:49:37 -0000


--+JUInw4efm7IfTNU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 20, 2013 at 07:44:34PM +0000, Andrey Zonov wrote:
> Author: zont
> Date: Sun Jan 20 19:44:33 2013
> New Revision: 245696
> URL: http://svnweb.freebsd.org/changeset/base/245696
>=20
> Log:
>   - Force inetd to have listen queue size to be set to the value of
>     kern.ipc.somaxconn instead of hardcoded value 64.

Hmm, I didn't know -1 can be provided to use default limit.
Would you mind documenting it in listen(2)?

>   Submitted by:	Andrey Ignatov <rdna@rdna.ru>
>   MFC after:	2 weeks
>=20
> Modified:
>   head/usr.sbin/inetd/inetd.c
>=20
> Modified: head/usr.sbin/inetd/inetd.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/usr.sbin/inetd/inetd.c	Sun Jan 20 17:48:56 2013	(r245695)
> +++ head/usr.sbin/inetd/inetd.c	Sun Jan 20 19:44:33 2013	(r245696)
> @@ -1387,7 +1387,7 @@ setsockopt(fd, SOL_SOCKET, opt, (char *)
>                  }
>          }
>  	if (sep->se_socktype =3D=3D SOCK_STREAM)
> -		listen(sep->se_fd, 64);
> +		listen(sep->se_fd, -1);
>  	enable(sep);
>  	if (debug) {
>  		warnx("registered %s on %d",

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--+JUInw4efm7IfTNU
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlD9ATMACgkQForvXbEpPzSg7wCfde9JAeCY8ZH/4CxX/Sr2nhO4
HpcAn2PmeVaWF0gwLNMLGhVgjyzj2tt8
=nLkh
-----END PGP SIGNATURE-----

--+JUInw4efm7IfTNU--