From owner-svn-src-all@freebsd.org Wed Dec 7 21:26:49 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 43329C6BE61; Wed, 7 Dec 2016 21:26:49 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2D868C2B; Wed, 7 Dec 2016 21:26:48 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id uB7LQlBW021618 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 7 Dec 2016 13:26:47 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id uB7LQlNC021617; Wed, 7 Dec 2016 13:26:47 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 7 Dec 2016 13:26:47 -0800 From: Gleb Smirnoff To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309658 - head/sys/vm Message-ID: <20161207212647.GO27748@FreeBSD.org> References: <201612062252.uB6Mqjhr019191@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201612062252.uB6Mqjhr019191@repo.freebsd.org> User-Agent: Mutt/1.7.0 (2016-08-17) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 21:26:49 -0000 On Tue, Dec 06, 2016 at 10:52:45PM +0000, Mark Johnston wrote: M> Author: markj M> Date: Tue Dec 6 22:52:45 2016 M> New Revision: 309658 M> URL: https://svnweb.freebsd.org/changeset/base/309658 M> M> Log: M> Provide dummy sysctls for v_cache_count and v_tcached. M> M> Some utilities (notably top(1)) exit if any of their input sysctls don't M> exist, and the removal of the above-mentioned PG_CACHE-related sysctls M> makes it difficult to run such utilities on different versions of the M> kernel without recompiling. M> M> Requested by: bde M> M> Modified: M> head/sys/vm/vm_meter.c M> M> Modified: head/sys/vm/vm_meter.c M> ============================================================================== M> --- head/sys/vm/vm_meter.c Tue Dec 6 22:48:28 2016 (r309657) M> +++ head/sys/vm/vm_meter.c Tue Dec 6 22:52:45 2016 (r309658) M> @@ -314,3 +314,14 @@ VM_STATS_VM(v_forkpages, "VM pages affec M> VM_STATS_VM(v_vforkpages, "VM pages affected by vfork()"); M> VM_STATS_VM(v_rforkpages, "VM pages affected by rfork()"); M> VM_STATS_VM(v_kthreadpages, "VM pages affected by fork() by kernel"); M> + M> +#ifndef BURN_BRIDGES M> +/* M> + * Provide compatibility sysctls for the benefit of old utilities which exit M> + * with an error if they cannot be found. M> + */ M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_cache_count, CTLFLAG_RD, M> + (u_int *)NULL, 0, "Dummy for compatibility"); M> +SYSCTL_UINT(_vm_stats_vm, OID_AUTO, v_tcached, CTLFLAG_RD, M> + (u_int *)NULL, 0, "Dummy for compatibility"); M> +#endif IMHO, there should be some garbage collecting timeout for them. I'd suggest to delete them from head after stable/12 branch is forked. -- Totus tuus, Glebius.