From owner-cvs-all Fri Sep 7 19:15:36 2001 Delivered-To: cvs-all@freebsd.org Received: from tao.org.uk (genius.tao.org.uk [212.135.162.51]) by hub.freebsd.org (Postfix) with ESMTP id 60E0B37B407; Fri, 7 Sep 2001 19:15:29 -0700 (PDT) Received: by tao.org.uk (Postfix, from userid 100) id 010D9F; Sat, 8 Sep 2001 03:15:27 +0100 (BST) Date: Sat, 8 Sep 2001 03:15:27 +0100 From: Josef Karthauser To: Peter Wemm Cc: Will Andrews , Ruslan Ermilov , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Contracting $FreeBSD: xxx $ in commits (Re: cvs commit: src/include stddef.h) Message-ID: <20010908031527.X3148@tao.org.uk> References: <20010525023459.E7406@casimir.physics.purdue.edu> <20010526220826.7CE6238CB@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="p+/4B2pcxE3X6xU6" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010526220826.7CE6238CB@overcee.netplex.com.au>; from peter@wemm.org on Sat, May 26, 2001 at 03:08:26PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --p+/4B2pcxE3X6xU6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 26, 2001 at 03:08:26PM -0700, Peter Wemm wrote: > Will Andrews wrote: > > On Fri, May 25, 2001 at 09:51:10AM +0300, Ruslan Ermilov wrote: > > > How that could be? Don't we count the '$FreeBSD$' line? > >=20 > > Not necessarily. Only when the previous commit that was made was made > > w/o the rcsid expanded. I've made several "+0 -0" commits before. :-) >=20 > If the previous commit had the tag changed to "$FreeBSD$" and the current > commit had it as "$FreeBSD$" then you get this. The tags are expanded > on *checkout*, not checkin. If you have: "$FreeBSD: is excellent $" > then that is what actually goes into the rcs files. >=20 > I have contemplated in the past making the commit checkin scripts change > any expanded $FreeBSD: foo $ tags into plain $FreeBSD$ so that it doesn't > keep occupying rcs delta space, but I was concerned about potential > interactions with remote commits and the 'touched but not actually > modified' checking. It would be worth experimenting with I think. It is > silly that we have +1 -1 on most commits solely because of the header > changes. I've just committed code to handle this. It works fine with remote commits in my tests, and the 'touched by not actually modified' issue doesn't appear to be one. Maybe it's a bug that was fixed in a more recent version of cvs? Joe --p+/4B2pcxE3X6xU6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjuZfz8ACgkQXVIcjOaxUBb9FQCg6rDjuGCP6N7YTL38h9w3ljKO EacAoI6jtOzVl7GhBmOlOwbQKX5Nge5j =hUCg -----END PGP SIGNATURE----- --p+/4B2pcxE3X6xU6-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message