From nobody Thu Apr 7 22:57:43 2022 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7CFEA1A9F16E for ; Thu, 7 Apr 2022 22:57:58 +0000 (UTC) (envelope-from SRS0=3XOE=UR=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KZGxb529gz4YZK for ; Thu, 7 Apr 2022 22:57:54 +0000 (UTC) (envelope-from SRS0=3XOE=UR=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id C4ADF20A327E for ; Fri, 8 Apr 2022 08:57:44 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id ADA72211421A for ; Fri, 8 Apr 2022 08:57:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nt.com.au; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:references:to:content-language:subject:subject :user-agent:mime-version:date:date:message-id; s=dkim; t= 1649372264; x=1651964265; bh=Vzt7pCOpVaWY6At218TrJWHkzpGA/pz4wJ8 2D+mI5eI=; b=HJrevRACuJAqJ8QPgFLIwDxQhyHx1/j8wYriRLBrDFSxcSBc4kh rDaxom8Er/ffRFcyGXSJ7KpHw0f8L1/75FvbRWmO3HiCzAtgnhv2Xs5X0fy5a0K3 tD8u3qLm9zaoXTP/14gHCDstZELvmASsLv5eTV+bQXDHfT/ru4yRWY1I= Received: from iredmail.onthenet.com.au ([127.0.0.1]) by iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zMZTfFW2he2j for ; Fri, 8 Apr 2022 08:57:44 +1000 (AEST) Received: from [192.168.1.102] (unknown [120.29.51.26]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 669A321141F9; Fri, 8 Apr 2022 08:57:43 +1000 (AEST) Message-ID: Date: Fri, 8 Apr 2022 08:57:43 +1000 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Content-Language: en-US To: =?UTF-8?Q?Corvin_K=c3=b6hne?= , Rebecca Cran , "devel@edk2.groups.io" Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , FreeBSD Virtualization , Gerd Hoffmann References: <20220329101417.617-1-c.koehne@beckhoff.com> <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> From: Peter Grehan In-Reply-To: <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=ONO8IRSB c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=8fVbGRnJaTNBnOEn7SCwoA==:17 a=IkcTkHD0fZMA:10 a=z0gMJWrwH1QA:10 a=6I5d2MoRAAAA:8 a=Nkxd-uETkxZAC2387MkA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 X-Rspamd-Queue-Id: 4KZGxb529gz4YZK X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=nt.com.au header.s=dkim header.b=HJrevRAC; dmarc=none; spf=none (mx1.freebsd.org: domain of "SRS0=3XOE=UR=freebsd.org=grehan@iredmail.onthenet.com.au" has no SPF policy when checking 203.13.68.12) smtp.mailfrom="SRS0=3XOE=UR=freebsd.org=grehan@iredmail.onthenet.com.au" X-Spamd-Result: default: False [-1.60 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[203.13.68.12:from]; DKIM_TRACE(0.00)[nt.com.au:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; FORGED_SENDER(0.30)[grehan@freebsd.org,SRS0=3XOE=UR=freebsd.org=grehan@iredmail.onthenet.com.au]; RCVD_IN_DNSWL_LOW(-0.10)[203.13.68.12:from]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:9313, ipnet:203.13.68.0/23, country:AU]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[grehan@freebsd.org,SRS0=3XOE=UR=freebsd.org=grehan@iredmail.onthenet.com.au]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RCVD_COUNT_FIVE(0.00)[5]; R_DKIM_ALLOW(-0.20)[nt.com.au:s=dkim]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TAGGED_RCPT(0.00)[tianocore]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[freebsd-virtualization]; SUSPICIOUS_RECIPS(1.50)[] X-ThisMailContainsUnwantedMimeParts: N On 4/7/22 3:24 PM, Corvin K=C3=B6hne wrote: > Hi Peter and Rebecca, >=20 > thanks for your feedback. This patch is backward compatible. It checks > if QemuFwCfg is available and if QemuFwCfg is missing it falls > back to BhyveFwCtl. >=20 > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > commit message? Acked-by: Peter Grehan