From owner-svn-src-all@FreeBSD.ORG Thu Jan 8 08:13:14 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AA3085CE; Thu, 8 Jan 2015 08:13:14 +0000 (UTC) Received: from mail-pd0-x233.google.com (mail-pd0-x233.google.com [IPv6:2607:f8b0:400e:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74C0BA9C; Thu, 8 Jan 2015 08:13:14 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id fp1so9792670pdb.10; Thu, 08 Jan 2015 00:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=SOyBD8itLUeEiHWiQS9T924nMqC4+XkdlaVbBzx5fO0=; b=t3lCP81pMy/b+OJJ3wxHeCK/R9spRPYNVt0uE63wWyD9pt2FPcA/xET1hsRIivStvz TFSCJaOi1giNl91o3ki/xHKbt19nZxdi17gQVA1/BfyHqAOT12fsJvXChhipzvFh3D0o zKwMOKnPDkFsG8NtlAkDt7LD3Rm8YR4bPWwanbrwh5uZ8jrJar38Nt9zui76AzPDyjrV ImJUeVBIFpuhBOLNZnnvQHlh1uahlFghEHXmuL99lrdJDAZHCqpjrJNDnV1+mFO75glD W4Ubs5t/HSm7p7Wr4/Kg2xFlCmMBhUva9frkOyW8G3IU9H95yAMTj4Rait63TwoJ2jqk vsQw== MIME-Version: 1.0 X-Received: by 10.70.35.109 with SMTP id g13mr2315795pdj.17.1420704793948; Thu, 08 Jan 2015 00:13:13 -0800 (PST) Sender: ermal.luci@gmail.com Received: by 10.70.91.232 with HTTP; Thu, 8 Jan 2015 00:13:13 -0800 (PST) In-Reply-To: References: <201501060903.t06934qp081875@svn.freebsd.org> <20150107204631.GG15484@FreeBSD.org> Date: Thu, 8 Jan 2015 09:13:13 +0100 X-Google-Sender-Auth: -frk1JuV_JeYCd2yC9-xu9hFjtI Message-ID: Subject: Re: svn commit: r276747 - head/sys/netpfil/pf From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= To: "Bjoern A. Zeeb" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: Craig Rodrigues , src-committers@freebsd.org, svn-src-all@freebsd.org, Nikos Vassiliadis , Gleb Smirnoff , svn-src-head@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jan 2015 08:13:14 -0000 On Thu, Jan 8, 2015 at 1:21 AM, Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > > > On 07 Jan 2015, at 20:46 , Gleb Smirnoff wrote: > > > > On Tue, Jan 06, 2015 at 09:03:04AM +0000, Craig Rodrigues wrote: > > C> Author: rodrigc > > C> Date: Tue Jan 6 09:03:03 2015 > > C> New Revision: 276747 > > C> URL: https://svnweb.freebsd.org/changeset/base/276747 > > C> > > C> Log: > > C> Instead of creating a purge thread for every vnet, create > > C> a single purge thread and clean up all vnets from this thread. > > C> > > C> PR: 194515 > > C> Differential Revision: D1315 > > C> Submitted by: Nikos Vassiliadis > > > > I am not sure that this is a good idea. The core idea of VNETs > > is that they are isolated from each other. If we serialize purging, > > then vnets are strongly affecting each other. > > > > AFAIU, from the PR there is some panic fixed. What is the actual bug > > and why couldn't it be fixed with having per-vnet thread? > > You don=E2=80=99t 30000 whatever pf purging threads on a system all runni= ng, > possibly competing for some resources, e.g., locks? > You can tune your system to your load! I do not agree with this change as well but just saw it! I would have agreed with this if a thread per CPU is created and some improvements in the locking strategy is performed! This is a potential issue since on busy system this thread gets very resource consuming! > > =E2=80=94 > Bjoern A. Zeeb Charles Haddon Spurgeon: > "Friendship is one of the sweetest joys of life. Many might have failed > beneath the bitterness of their trial had they not found a friend." > > > --=20 Ermal