From owner-svn-src-all@freebsd.org Fri Jan 11 17:10:36 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76CA2149610E; Fri, 11 Jan 2019 17:10:36 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D167174895; Fri, 11 Jan 2019 17:10:35 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x0BHAXZF022140; Fri, 11 Jan 2019 09:10:33 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x0BHAXsr022139; Fri, 11 Jan 2019 09:10:33 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201901111710.x0BHAXsr022139@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth usr.sbin/bluetooth/bluetooth-config In-Reply-To: <20190111164754.GB1267@e.0x20.net> To: Lars Engels Date: Fri, 11 Jan 2019 09:10:33 -0800 (PST) CC: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: D167174895 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.96)[-0.964,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 17:10:36 -0000 > On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote: > > > Author: lme (ports committer) > > > Date: Fri Jan 11 15:52:09 2019 > > > New Revision: 342945 > > > URL: https://svnweb.freebsd.org/changeset/base/342945 > > > +.Nm > > > +utility first appeared in > > > +.Fx 12.1 . > > > +.Sh AUTHORS > > > +.An Dirk Engling Aq Mt erdgeist@erdgeist.org > > > +.Sh THANKS TO > > > +Lars Engels and Warren Block for suggestions, help, and testing. > > > > The contents of this file appear twice???? > > Yes, sorry. My fault. Bapt already fixed this in r342947. It was in the differential that way too and no one noticed :-( > > > > > Added: head/usr.sbin/bluetooth/bluetooth-config/bluetooth-config.sh > > > ============================================================================== > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > > +++ head/usr.sbin/bluetooth/bluetooth-config/bluetooth-config.sh Fri Jan 11 15:52:09 2019 (r342945) > > > @@ -0,0 +1,275 @@ > > > +#!/bin/sh > > > +#- > > > +# Copyleft 2019 Dirk Engling > > > > That implies the GPL, would you be willing to change it to > > what it appears your actually asserting, a Copyright, please. > > I just asked Dirk if I can change this to "Copyright". It was a mistake > on his side and he agrees to the change. Great, thanks. > > > > > +# > > > +# This script is released under the beerware license. > > > > Incomplete and none deterministic license reference, > > this needs to be corrected in some way, preferable > > with the text of the beerware license so there is > > no doubt as to what applies. > > I'll add the Beerware header. Again thanks. > > > +# After function definitions, main() can use them > > > +main "$@" > > > + > > > +exit > > > + > > > +# TODO > > > +# * If device is a keyboard, offer a text entry test field and if it does > > > +# not succeed, leave some clues for debugging (i.e. if the node responds > > > +# to pings, maybe switch keyboard on/off, etc) > > > +# * Same if device is a mouse, i.e. hexdump /dev/sysmouse. > > > +# * If device offers DUN profiles, ask the user if an entry in > > > +# /etc/ppp/ppp.conf should be created > > > +# * If OPUSH or SPP is offered, refer to the respective man pages to give > > > +# some clues how to continue > > > > > > > > > > The style of this .sh does not match the normal style of > > such things in base, especially with respect to long lines > > and indentation. > > Do we have a style guide for shell scripts in base? How should > indentation look like? Not that I can locate, but I can state that almost all of the base code uses tab indenting and limited to 80 column widths, independent of c, sh, make, etc. -- Rod Grimes rgrimes@freebsd.org