From owner-svn-src-stable@freebsd.org Tue May 2 22:58:42 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91410D5B7E5; Tue, 2 May 2017 22:58:42 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5C07A9F8; Tue, 2 May 2017 22:58:41 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-oi0-f43.google.com with SMTP id b204so3902195oii.1; Tue, 02 May 2017 15:58:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eWrtCfgh66ncfUnX7bKFXXfmcysliwDHXMRh3/wAjQE=; b=ZgsVP11k1v97sTbEJW/yjI0U01EtH4clEmaIsQLZ0v687llkQhvmkAiGtaobcJPPfh PXfjV+ckLasFDYeh7FMbujH4o7VSjFTFfDaNvUzf/TkF7pO3bPkK2csw8fIYrgb4MnuI SIWeFKMUdzlErvq5OmdCQsMHH36tXXeTOMnR9RBJjR1dRMLP6+7NMJNLhGFEt04uNvVo lIGfqFGZRZYvJm67r+aMk/xASIHxzjxtS23ueUnQ4M4Rjab1VxUuMjGV2AnMWIFzc+v7 6urkyEnXq+XOjSlH6+bqpCHOrdUFL3f+7iMdbkeZwfBqtLT6x/Ftxbn3QXiW0HWGfAgd mseg== X-Gm-Message-State: AN3rC/4aopk2bNhoATSphgqB05nKXoiqn8DJ3yn0PrgaLSy04RGfd1ay Y2vRYGPTbUGEE44RTPs= X-Received: by 10.157.35.69 with SMTP id k5mr12164467otd.49.1493765915627; Tue, 02 May 2017 15:58:35 -0700 (PDT) Received: from mail-oi0-f52.google.com (mail-oi0-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id c126sm8919470oia.5.2017.05.02.15.58.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 May 2017 15:58:35 -0700 (PDT) Received: by mail-oi0-f52.google.com with SMTP id w10so15892252oif.0; Tue, 02 May 2017 15:58:34 -0700 (PDT) X-Received: by 10.157.24.86 with SMTP id t22mr6859692ott.145.1493765914832; Tue, 02 May 2017 15:58:34 -0700 (PDT) MIME-Version: 1.0 References: <201703152120.v2FLKHUs052999@repo.freebsd.org> In-Reply-To: From: Eric Joyner Date: Tue, 02 May 2017 22:58:24 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv To: Ngie Cooper , Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-10@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 22:58:42 -0000 I fixed the netmap build for amd64 at least with r317711. I'm running a tinderbox build on it now, though, so I'll see if that fixes it. On Fri, Apr 28, 2017 at 1:40 PM Eric Joyner wrote: > I notified Jeb (the original patch submitter) about that netmap symbol > issue, but we've both been distracted with other development. I'll work on > updating it. > > - Eric > > On Thu, Apr 27, 2017 at 3:06 PM Ngie Cooper wrote: > >> On Thu, Apr 27, 2017 at 1:07 PM, Ed Maste wrote: >> > On 15 March 2017 at 17:20, Eric Joyner wrote: >> >> Author: erj >> >> Date: Wed Mar 15 21:20:17 2017 >> >> New Revision: 315333 >> >> URL: https://svnweb.freebsd.org/changeset/base/315333 >> >> >> >> Log: >> >> ixgbe(4): Update to 3.2.11-k >> > >> > This broke tinderbox on many architectures: >> > >> > ia64 GENERIC and powerpc GENERIC64: >> > >> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no >> > previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes] >> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no >> > previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes] >> > >> > sparc64 LINT: >> > >> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning: >> > redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls] >> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning: >> > previous declaration of 'ix_crcstrip' was here >> > >> > amd64 LINT: >> > >> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0): >> > multiple definition of `ixgbe_netmap_attach' >> > >> ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0): >> > first defined here >> >> Hi Ed, >> >> It has to do with netmap(4) refactoring on head not being backported, >> in combination with ixgbe/ix being MFCed in a refactored state back to >> ^/stable/10 (it wasn't easy to backport due to PCI-IOV only being on >> ^/stable/10 -- I tried starting this work and failed because I lacked >> the hardware to test this out with). >> >> This has been known to be broken for almost two months -- a surgical >> fix should probably be applied to do what's required to make the >> symbol appear in the appropriate places, since this basically was a >> direct commit to ^/stable/10 in some regards. >> >> Thanks, >> -Ngie >> >