From owner-svn-src-head@freebsd.org Thu Jan 21 21:13:10 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EF640A8CAA3; Thu, 21 Jan 2016 21:13:09 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-ig0-x231.google.com (mail-ig0-x231.google.com [IPv6:2607:f8b0:4001:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA84F1271; Thu, 21 Jan 2016 21:13:09 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-ig0-x231.google.com with SMTP id ik10so133094950igb.1; Thu, 21 Jan 2016 13:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=C8oPKF6QAE1oc/tNlNatLCuMjiDNWzLZjdW3PVMQzgI=; b=rf+b7vHIt85zGKTYGckESqz1TrYj6uPFaAvGc7mqIrzN57p8MYUoeOSqE6Xox0qNrt GouOEU4hojobQDMNoOpCPVq+nylMPFjjc/kPKVNfmwdnlCcMEvroFpWavHCosdolIEL2 aJw1TrdhH2CbdyTbt1qoN6wWicjQRJbQA0pQ4GH9r05Wi6kOs3CZ2omrOrWVPIKsvISz qBmbr6SwAo1U8sNvrZ79o9Q/305P/BekjDtb7E+JmeSX72nXaye3VuOnTYYWjnYgMKD1 bGanHAfG7u+ZzqIT+tW2SwJRPM5YkAHf1wgORsNvG3ctpeSo7ljFbtzNjKPb+7fCAmLL cvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=C8oPKF6QAE1oc/tNlNatLCuMjiDNWzLZjdW3PVMQzgI=; b=e0iUmip0QRovCbL1Nqop3jW1EQrdxfTl3uIMF4og9r92kh9LeckIepGITxVpSRZ31W ZC4cMcenzhynSo3+Ux+rdGEv7it+3zuLovfUnPbDRB35Ge7/oQjO2LvptTrVZh/KnbBD amI1mCcH9P26UqCGzcY9SRpRzbWKEiyFDIoAx2MRAVHAQNIdp/7djoQU8jOiWVPgL8GS jV4DfrQo5fS6TrMBdeASkl/Xn83UDvCMRBEFERaBg5DMoxBw5WyyCW766uBlF4i+3kvF 8dZ9HfyDL0y8ELGGhuqJJAPmo/xOSAkZ2t3d9k42RY+77094v2EHIk+ISciCa1mn0wl1 33gA== X-Gm-Message-State: AG10YOSxH0cPffGolixs9YKUaGlJQzrWc0vBC0YW9AW0sUw07UsG5axzzojsms65mq+oRR+6UUwlufmtgRf2gg== X-Received: by 10.50.55.98 with SMTP id r2mr10655213igp.97.1453410789134; Thu, 21 Jan 2016 13:13:09 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.39.66 with HTTP; Thu, 21 Jan 2016 13:12:49 -0800 (PST) In-Reply-To: <2651E939-BCCD-4013-A4EB-717CA2496563@FreeBSD.org> References: <201601212044.u0LKiLL9077696@repo.freebsd.org> <2651E939-BCCD-4013-A4EB-717CA2496563@FreeBSD.org> From: Ed Maste Date: Thu, 21 Jan 2016 16:12:49 -0500 X-Google-Sender-Auth: 6tKvsQkL_twuBalDq-1_55IMIRM Message-ID: Subject: Re: svn commit: r294530 - head/sys/sys To: Renato Botelho Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2016 21:13:10 -0000 On 21 January 2016 at 16:00, Renato Botelho wrote: >> On Jan 21, 2016, at 18:44, Ed Maste wrote: >> >> Author: emaste >> Date: Thu Jan 21 20:44:21 2016 >> New Revision: 294530 >> URL: https://svnweb.freebsd.org/changeset/base/294530 >> >> Log: >> Add STB_GNU_UNIQUE symbol binding definition >> >> Red Hat created STB_GNU_UNIQUE to handle certain special cases relating >> to dynamically loading C++ DSOs[1]. >> >> We don't (currently) have support for STB_GNU_UNIQUE, but ought to >> reserve the value in ELFNN_ST_BIND. This will also be used by an >> upcoming ELF Tool Chain import. >> >> [1] https://www.redhat.com/archives/posix-c++-wg/2009-August/msg00002.html >> >> MFC after: 1 week >> Sponsored by: The FreeBSD Foundation >> >> Modified: >> head/sys/sys/elf_common.h >> >> Modified: head/sys/sys/elf_common.h >> ============================================================================== >> --- head/sys/sys/elf_common.h Thu Jan 21 19:19:24 2016 (r294529) >> +++ head/sys/sys/elf_common.h Thu Jan 21 20:44:21 2016 (r294530) >> @@ -753,8 +753,9 @@ typedef struct { >> #define STB_LOCAL 0 /* Local symbol */ >> #define STB_GLOBAL 1 /* Global symbol */ >> #define STB_WEAK 2 /* like global - lower precedence */ >> -#define STB_LOOS 10 /* Reserved range for operating system */ >> -#define STB_HIOS 12 /* specific semantics. */ >> +#define STB_LOOS 10 /* Start of operating system reserved range. */ >> +#define STB_GNU_UNIQUE 10 /* Unique symbol (GNU) */ > > Looks like you meant to use 11 here, no? No, it is supposed to be 10. STB_LOOS is a placeholder for the first OS-specific entry, and STB_GNU_UNIQUE is the first one. It's similar to STT_GNU_IFUNC (which we do use) -- it has the same value as STT_LOOS. These two are really more of a toolchain concern than a "GNU OS," but either way STB_GNU_UNIQUE has the value 10, and if we end up supporting this functionality we'll use the same value.