Date: Wed, 09 Jan 2019 15:50:25 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234791] sysutils/node_exporter: Add license file, tests, docs and examples Message-ID: <bug-234791-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234791 Bug ID: 234791 Summary: sysutils/node_exporter: Add license file, tests, docs and examples Product: Ports & Packages Version: Latest Hardware: Any URL: https://reviews.freebsd.org/D18792 OS: Any Status: New Keywords: needs-qa, patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: 0mp@FreeBSD.org CC: ports@ecadlabs.com CC: ports@ecadlabs.com Flags: maintainer-feedback?(ports@ecadlabs.com) Created attachment 200957 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200957&action= =3Dedit Patch - Define LICENSE_FILE - Sort variables - Add a do-test target and prepare a testing environment. One test is skip= ped at the moment due to a problem with detecting procfs(5) on FreeBSD. - Install documentation and examples. - Change pkg-descr to better match upstream's README. I am not sure about a couple of things, however: Is it fine to use USES=3Dgmake instead of TEST_DEPENDS=3Dgmake:devel/gm= ake? USES=3Dgmake adds a dependency to the build process, which is not ideal. The whole pre-test target is rather hacky. I was unable to come up with= a prettier solution though. Go is a little bit hard to tame. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234791-7788>