From owner-freebsd-arch  Sun Sep 30  1: 3:39 2001
Delivered-To: freebsd-arch@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8AB7037B406; Sun, 30 Sep 2001 01:03:34 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA08823;
	Sun, 30 Sep 2001 18:03:30 +1000
Date: Sun, 30 Sep 2001 18:02:54 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@delplex.bde.org>
To: John Baldwin <jhb@FreeBSD.ORG>
Cc: Peter Wemm <peter@wemm.org>, <arch@FreeBSD.ORG>,
	Warner Losh <imp@harmony.village.org>,
	Julian Elischer <julian@elischer.org>
Subject: Re: Style Wars
In-Reply-To: <XFMail.010928165401.jhb@FreeBSD.org>
Message-ID: <20010930175137.T70218-100000@delplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

On Fri, 28 Sep 2001, John Baldwin wrote:

> I'm think 1b) is the one most people have favored so far and it is rather close
> to our existing style, so it's not that big of a change.  Does anyone object to
> 1b)?  It basically results in the following changes: use 2 tab spaces instead
> of 1 for type names, put the entire type name before the tab(s), and if the
> type is too long, just use a space.
>
> > 1b)
> >
> > struct foo {
> >         int             f_type;
> >         struct mtx      f_lock;
> >         const char      *f_name;
> >         volatile int    f_int;
> >         u_int64_t       f_64;
> >         const volatile char f_cv;
> >         TAILQ_ENTRY(foo) f_link;
> > };

Yes, this is essentially just the current style with encouragement for
more verboseness.  It's interesting that indent(1) defaults to the
too-large indent of 16 (-di16).  I wouldn't want to go back to that
:-).  I prefer to use 1 space after the typename, but for FreeBSD I
don't mind using 1 tab after short typenames.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message