From owner-svn-src-all@FreeBSD.ORG Sun Oct 5 21:40:13 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C5D574E2; Sun, 5 Oct 2014 21:40:13 +0000 (UTC) Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com [IPv6:2a00:1450:400c:c05::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 91DE2E63; Sun, 5 Oct 2014 21:40:12 +0000 (UTC) Received: by mail-wi0-f169.google.com with SMTP id cc10so5269501wib.0 for ; Sun, 05 Oct 2014 14:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rYPbgL9D4gKtSEDcWyRRHnlpanHW+LfVwNqYqBcS2k4=; b=Hvi2oDXxyKQZG7+a0J8lPXnbvErCdqIKnREuR52dqXjhjymA17qeNxV3r/g/SSnPo3 aKgjqd6bKX0fYTBpOYckz40SANgNriVGPWpFmcS3oC12WK36ovJTNguTB3zZTslxmpbo 93IJvWTbYMLdnygKgMcTFL08t4BtEcOIp5cITN2Pi9rxm4h/9R8+pYMz876mk9TkQDHB ghH8GvW7UWMwxmKny2ECc3OfPQYmKgYpPoHzERU596Nqa9AwkQ4+beWv/QxyFrdsKc4G oMlMp3kS22axfDKKIeEiA8B7yN/qyaxEYY0eP7apVH73J5gY+CWmL3SlIARgJUQGXh/l gRFA== X-Received: by 10.195.12.46 with SMTP id en14mr18810576wjd.95.1412545210921; Sun, 05 Oct 2014 14:40:10 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id ma8sm15145855wjb.46.2014.10.05.14.40.09 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 05 Oct 2014 14:40:10 -0700 (PDT) Date: Sun, 5 Oct 2014 23:40:07 +0200 From: Mateusz Guzik To: "Bjoern A. Zeeb" Subject: Re: svn commit: r272567 - in head/sys: kern sys Message-ID: <20141005214006.GF9262@dft-labs.eu> References: <201410051940.s95JeUg7069798@svn.freebsd.org> <2438AED3-AC72-4099-ACD6-E2642B4A866D@FreeBSD.org> <20141005204716.GE9262@dft-labs.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20141005204716.GE9262@dft-labs.eu> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov , Mateusz Guzik X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Oct 2014 21:40:13 -0000 On Sun, Oct 05, 2014 at 10:47:16PM +0200, Mateusz Guzik wrote: > On Sun, Oct 05, 2014 at 08:26:59PM +0000, Bjoern A. Zeeb wrote: > > > > On 05 Oct 2014, at 19:40 , Mateusz Guzik wrote: > > > > > Author: mjg > > > Date: Sun Oct 5 19:40:29 2014 > > > New Revision: 272567 > > > URL: https://svnweb.freebsd.org/changeset/base/272567 > > > > > > Log: > > > filedesc: fix up breakage introduced in 272505 > > > > > > Include sequence counter supports incoditionally [1]. This fixes reprted build > > > problems with e.g. nvidia driver due to missing opt_capsicum.h. > > > > > > Replace fishy looking sizeof with offsetof. Make fde_seq the last member in > > > order to simplify calculations. > > > > Seing this on an incremental build now for > > > > bmake: stopped in /scratch/tmp/bz/head.svn/lib/libkvm > > > > /storage/head/obj//mips.mipsel/scratch/tmp/bz/head.svn/tmp/usr/include/sys/filedesc.h:57: error: expected specifier-qualifier-list before 'seq_t' > > > > I’ll see if this persists with a full build but I assume it will. > > > > I cannot reproduce it, tried with mips + QEMU config. > > One crap thing is that typedef uint32_t seq_t is placed before includes. > > Does it help if you move it after systm.h? > > Was the failure present prior to this patch? > Sigh, sorry, totally misread what you wrote. Fixed in r272574. -- Mateusz Guzik