Date: Mon, 14 May 2012 14:37:26 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: x11@freebsd.org, current@freebsd.org Subject: Re: Intel GPU driver import Message-ID: <20120514113726.GH2358@deviant.kiev.zoral.com.ua> In-Reply-To: <4FB0ED1A.3020909@FreeBSD.org> References: <20120512213950.GZ2358__17671.8018287376$1336859020$gmane$org@deviant.kiev.zoral.com.ua> <4FB0ED1A.3020909@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--JD3qPFYKz0/ozIPR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 14, 2012 at 02:31:38PM +0300, Andriy Gapon wrote: > on 13/05/2012 00:39 Konstantin Belousov said the following: > > With r235375, all required VM support for new Intel GPU driver was > > committed into HEAD. There are still some things to improve and > > change, but now the all.14.9.patch does not touch anything outside agp > > or drm. This allows to start the process of importing the new Intel > > GPU driver into HEAD. > >=20 > > I am writing this as initial head-up and to discuss some questions, > > for which I do have answers but would prefer to have additional > > feedback from people doing Xorg work. > >=20 > > The patch as-is just replaces the Intel DRI1 bits with DRI2 > > driver. Patch added most of the KMS infrastructure into DRM > > core. Also, patch completely changed the locking model used by Intel > > driver. I made absolutely minimal efforts needed to keep other DRI1 > > drivers compilable. Despite that, I got several surpising reports that > > Radeon DRI1 still works. > >=20 > > That said, for import I can (first choice) just apply the patch, > > replacing the Intel driver with new one. Or (second choice) I may > > create another directory, say sys/dev/drm2, and import _only_ Intel > > driver together with updated DRM core, there. > >=20 > > The positive points to the second approach is that we still have older > > kernel drivers around. Also, I have more freedom in changing the DRM > > core, without fearing breakage in the DRI1 land. Since I do not really > > want to deal with Gen2-3 hardware, and VGA console does not work with > > new driver (yet), there are definite advantages. > >=20 > > On the other hand, driver automatic loading will not work with > > dev/drm2 approach. New driver have to use different module name to > > co-exist with dri1 driver, so ddx driver cannot load new driver by old > > name. As result, users need to manually kldload new driver before > > starting Xorg. > >=20 > > My own preference is to implement second choice and put the driver > > into dev/drm2. >=20 >=20 > I think that I would prefer this path too for the reasons you already men= tioned above: > - potential problems for other drivers > - need to easily fallback for those who use the intel driver and may run = into > problems with the new code > - some missing bits related to kms like syscons support, which makes > troubleshooting harder >=20 > BTW, I think that we should patch xf86-video-intel port to try loading > "i915kms"/"i915gem"/... if i915 is not available. I think that that shou= ld be > fine for a FreeBSD-specific patch. > Alternatively, we could keep the same names for drivers/modules and then = have a > global knob (WITH_DRM2/WITH_KMS/etc) to select which source is code is us= ed to > build the drivers. No, I want both drivers to be presented in /boot/kernel in default=20 install. Also, I want to avoid forcing user to recompile her kernel for driver switching. Regarding the patching xf86-video-intel, I am completely fine with this, but the work should be done by xorg porters. Assuming they will to do this and then maintain the (should be quite trivial) patch. And I like the 'i915kms' name for the module. This and drm2.ko for core drm infrastructure sound good, thank you. --JD3qPFYKz0/ozIPR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+w7nYACgkQC3+MBN1Mb4gNMACg5BN/FrMl/d5qf12ZIp6jIwyF Z7sAoNt/T6Kq4ZSFfzyAVxt7+X7EKWzh =znef -----END PGP SIGNATURE----- --JD3qPFYKz0/ozIPR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120514113726.GH2358>