Date: Thu, 4 Jan 2024 12:49:03 -0700 From: Warner Losh <imp@bsdimp.com> To: Jamie Landeg-Jones <jamie@catflap.org> Cc: Tomoaki AOKI <junchoon@dec.sakura.ne.jp>, Brooks Davis <brooks@freebsd.org>, Yuri <yuri@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, Bakul Shah <bakul@iitbombay.org> Subject: Re: git repo port issues? Message-ID: <CANCZdfrUHDbWd7_SzsF67be6xjpXPVQUD5y33DPpD-tO_0UMTw@mail.gmail.com> In-Reply-To: <202401041914.404JEJCm083648@donotpassgo.dyslexicfish.net> References: <202401031913.403JDZBt028036@donotpassgo.dyslexicfish.net> <ZZWz-14AXfcSY2AD@spindle.one-eyed-alien.net> <46C8698A-A004-4B5F-9107-6D9FD3685074@iitbombay.org> <ZZXui1gm0IIVoWca@spindle.one-eyed-alien.net> <20240104183539.cef54811b98fe53c5841edca@dec.sakura.ne.jp> <202401041914.404JEJCm083648@donotpassgo.dyslexicfish.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Jan 4, 2024, 12:14 PM Jamie Landeg-Jones <jamie@catflap.org> wrote: > Tomoaki AOKI <junchoon@dec.sakura.ne.jp> wrote: > > > > > Or create database (key-value store would be sufficient) storing commit > > order (like r* of svn) and commit hash. > > I'm still not certain whether commit order or commit hash should be the > > "key". Possibly store hash as the key fisrt and store assigned MONOTONIC > > order as value, then, add the just-stored order as key and hash as > > value in another database would be neeed. If the database can contain 2 > > value for 1 key, it would be suitable for you to store the assigned > > time in UTC as "when it is committed to FreeBSD master repo". > > I do miss the incrementing "r" value - it's a nice immediate way to > tell which update is more recent. Actually, to me, that is more important > than the date - I've attempted to base my changes on the date due to the > absense of such a useful field. > See sys/conf/newvers.sh for the 'n' value we use in uname strings. It's a linear count of commits on the first-parent branch back to the start of the repo. Also, the dates usualy are first order correct and i use them for the stats i run. Though I've also just dropped tags on the first commit of each year too... Also be advised that the pre FreeBSD 8 or so tree still has some surprising artifacts in it. Warner Actually, I think I may implement such a thing on my local cgit repo. > > https://cgit.dyslexicfish.net/ports/latest/tree/ > https://cgit.dyslexicfish.net/src/current/tree/ > > Cheers, Jamie > > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jan 4, 2024, 12:14 PM Jamie Landeg-Jones <<a href="mailto:jamie@catflap.org">jamie@catflap.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Tomoaki AOKI <<a href="mailto:junchoon@dec.sakura.ne.jp" target="_blank" rel="noreferrer">junchoon@dec.sakura.ne.jp</a>> wrote:<br> <br> ><br> > Or create database (key-value store would be sufficient) storing commit<br> > order (like r* of svn) and commit hash.<br> > I'm still not certain whether commit order or commit hash should be the<br> > "key". Possibly store hash as the key fisrt and store assigned MONOTONIC<br> > order as value, then, add the just-stored order as key and hash as<br> > value in another database would be neeed. If the database can contain 2<br> > value for 1 key, it would be suitable for you to store the assigned<br> > time in UTC as "when it is committed to FreeBSD master repo".<br> <br> I do miss the incrementing "r" value - it's a nice immediate way to<br> tell which update is more recent. Actually, to me, that is more important<br> than the date - I've attempted to base my changes on the date due to the<br> absense of such a useful field.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">See sys/conf/newvers.sh for the 'n' value we use in uname strings. It's a linear count of commits on the first-parent branch back to the start of the repo.</div><div dir="auto"><br></div><div dir="auto">Also, the dates usualy are first order correct and i use them for the stats i run. Though I've also just dropped tags on the first commit of each year too...</div><div dir="auto"><br></div><div dir="auto">Also be advised that the pre FreeBSD 8 or so tree still has some surprising artifacts in it.</div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Actually, I think I may implement such a thing on my local cgit repo.<br> <br> <a href="https://cgit.dyslexicfish.net/ports/latest/tree/" rel="noreferrer noreferrer" target="_blank">https://cgit.dyslexicfish.net/ports/latest/tree/</a><br>; <a href="https://cgit.dyslexicfish.net/src/current/tree/" rel="noreferrer noreferrer" target="_blank">https://cgit.dyslexicfish.net/src/current/tree/</a><br>; <br> Cheers, Jamie<br> <br> </blockquote></div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrUHDbWd7_SzsF67be6xjpXPVQUD5y33DPpD-tO_0UMTw>