From owner-cvs-src@FreeBSD.ORG  Tue Oct 14 10:48:20 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B626116A4BF
	for <cvs-src@FreeBSD.org>; Tue, 14 Oct 2003 10:48:20 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 4F46A43FD7
	for <cvs-src@FreeBSD.org>; Tue, 14 Oct 2003 10:48:13 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 31132 invoked by uid 1000); 14 Oct 2003 17:48:14 -0000
Date: Tue, 14 Oct 2003 10:48:14 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Hajimu UMEMOTO <ume@FreeBSD.org>
In-Reply-To: <20031014133812.8478616A573@hub.freebsd.org>
Message-ID: <20031014104645.L31046@root.org>
References: <20031014133812.8478616A573@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/crypto/rijndael rijndael-api-fst.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Oct 2003 17:48:20 -0000

On Tue, 14 Oct 2003, Hajimu UMEMOTO wrote:
>   Modified files:
>     sys/crypto/rijndael  rijndael-api-fst.c
>   Log:
>   Fix alignment problem on 64 bit arch.
>   I only tested if it doesn't break anything on i368.  Since I
>   have no 64 bit machine, I cannot test it, actually.
>
>   Reported by:    jmallett
>
>   Revision  Changes    Path
>   1.9       +49 -0     src/sys/crypto/rijndael/rijndael-api-fst.c
>
> Index: src/sys/crypto/rijndael/rijndael-api-fst.c
> diff -u src/sys/crypto/rijndael/rijndael-api-fst.c:1.8 src/sys/crypto/rijndael/rijndael-api-fst.c:1.9
> --- src/sys/crypto/rijndael/rijndael-api-fst.c:1.8	Sun Oct 12 14:05:05 2003
> +++ src/sys/crypto/rijndael/rijndael-api-fst.c	Tue Oct 14 06:37:37 2003
> @@ -103,7 +103,11 @@
>  int rijndael_blockEncrypt(cipherInstance *cipher, keyInstance *key,
>  		BYTE *input, int inputLen, BYTE *outBuffer) {
>  	int i, k, t, numBlocks;
> +#if 1 /*STRICT_ALIGN*/
> +	u_int8_t block[16], iv[16];
> +#else
>  	u_int8_t block[16], *iv;
> +#endif
>
>  	if (cipher == NULL ||
>  		key == NULL ||

Allocating data on the stack does not give you guaranteed alignment.

-Nate