From owner-freebsd-ports@freebsd.org Mon Dec 11 05:55:27 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A97D5E872F7 for ; Mon, 11 Dec 2017 05:55:27 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-ua0-x229.google.com (mail-ua0-x229.google.com [IPv6:2607:f8b0:400c:c08::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DE14733DF; Mon, 11 Dec 2017 05:55:27 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: by mail-ua0-x229.google.com with SMTP id q13so11166796uaq.8; Sun, 10 Dec 2017 21:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=bH0ooVy1ZHvs4Q12GRO4eBfAwZGkBqu65vZnkHaekwk=; b=s/yFAFqIY+RnkHys1679s94HV1YZOW8I2+X+Fwq6VBgcv2HBj8EWzHCy2Skv4awGco tbnAKKuYYlLGx9aRZrkSKCOORYgdAALMuyZpGWv950dMpDo9dQpYGhICb5h0ItEUrr6p MgGtGNrKABfNROot1ctf7Yh4FYP/ElC3QLQduAOcXPWxnH2NTN3kpOaa7rOPmRzsCHy/ wRd1HuamAil+e2shWgwERBxRsRYvfy4VwfwwBiFxs6MkcJje0702j0VkaGBBfldEL1ws pIp+5kEJzhN94ZtRz6J8UX2MyQoMRqw8FQovcpEVQrKBpWCR8n2pzksavOhND4xQiMAA ChvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=bH0ooVy1ZHvs4Q12GRO4eBfAwZGkBqu65vZnkHaekwk=; b=QXjopkAXgxR/rWC/zYgLw7VCHhWD+mJ+LHC2Kul4Kh68g1WgxVxKKi8hOp+PcyMrXA 5G0dKbqysGyQtdEwj/o0xF0XgVSElu/CbT542PS6B3e01akeVXGvxtaNUgk+9LkPKDIY RbFejdZxHYCrOxtxyzXGrP1CmDMlaBPx7swNVNX4vMfvxXtDdOpTzSjkOuH9tiqF+ajS RZbx3S671gYCeEDBo3Foe1KrB+y8zE4Uj0//UiqeY1ToLt9o+hHQeyn5V8FLI2whcdNQ hay0WFrNESWVpTm1J2aIK2b6uxFA4KeSJaIU77TPulfIlD3sSl3WaO3uDm/dKxpaV1pr UAcQ== X-Gm-Message-State: AKGB3mJlOblr9kUWbAOMeuo0ey0IZOvDeOD4+MG69OzMJxRjsEqhScMP W9UCFKwwzDzVUofyQjWRBMKn1zlNueOrqJU2BUOiFQ== X-Google-Smtp-Source: AGs4zMa1mcfv/K1Q9tHIlTCFypF82cLG+/+J4kK6IR6bGplSNsHCXb/Tmy/+0ZsWzZZLAnz7FZAZfOpjicjEAZdpd24= X-Received: by 10.176.86.88 with SMTP id z24mr26161506uaa.41.1512971726061; Sun, 10 Dec 2017 21:55:26 -0800 (PST) MIME-Version: 1.0 Sender: kob6558@gmail.com Received: by 10.103.147.156 with HTTP; Sun, 10 Dec 2017 21:55:25 -0800 (PST) In-Reply-To: <20171210224216.GN78437@eureka.lemis.com> References: <20171210224216.GN78437@eureka.lemis.com> From: Kevin Oberman Date: Sun, 10 Dec 2017 21:55:25 -0800 X-Google-Sender-Auth: 16_KOIYk9FHdVP5sRfTmeUivrIE Message-ID: Subject: Re: make reinstall does not work To: "Greg 'groggy' Lehey" Cc: Walter Schwarzenfeld , FreeBSD Ports ML Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 05:55:27 -0000 On Sun, Dec 10, 2017 at 2:42 PM, Greg 'groggy' Lehey wrote: > On Sunday, 10 December 2017 at 20:32:38 +0100, Walter Schwarzenfeld wrote: > > Look at the link in Shawn Webb's post: > > > > bapt (Baptisse Daroussin) wrote > > > > *bapt * replied Nov 16, 2017 > > 7991c49665419916210ad589d4a85fd2a7f58b37#commitcomment-25649084> > > You should have quoted that in your reply. And are we really now > using github as the primary repository? > > > because it should have always been like that, the real > > reinstallation was make deinstall reinstall, the fact one needs not > > to run deinstall first was a bug introduced very very long ago > > This doesn't make much sense to me. If I do a make deinstall, the > package is gone. Then all I need is a make install, and that does, > indeed, work. make reinstall by itself also used to work. I'll go > with the others and assume that this was a transient bug. > > Greg > -- > Sent from my desktop computer. > Finger grog@FreeBSD.org for PGP public key. > See complete headers for address and phone numbers. > This message is digitally signed. If your Microsoft mail program > reports problems, please read http://lemis.com/broken-MUA > interesting! I know that the procedure back in the pre-portupgrade days was make, make deinstall, make reinstall, make clean. I looked at the code back then and reinstall did different things to the old, pre-pkgng, ports DB than install. I don't recall the details, but they are probably in the ancient parts of the svn repo. That said, the current version of reinstall clearly could failed in an ugly way as it does not ever uninstall the old port, just installs the new one which could easily leave any files that is no longer a part of the port in the $LOCALDIR. Not good! What is needed is to make the reinstall target properly handle the error of reinstalling a port that is still installed. "Error 70" is really not a good message,