From nobody Sat May 20 20:32:34 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QNwPZ3yD9z4BVLp for ; Sat, 20 May 2023 20:32:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QNwPZ2VMzz45w2 for ; Sat, 20 May 2023 20:32:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684614754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=svEMQ9QSsGFXrvq2hDHyn0NAyyVHWDnw2oD8aAvLnRg=; b=KGoMvm/2BpJMPbFOvV+APNVvrKJo4Ca1supP7NGAwT2yaO7ZKJCSbe2DW62YV2kdbsd7FM 4sTtoQih36n6bP+cPCuy6Z2SvuF8H7hXDxJ+pbFF7lq3zgMiRbZXZHywLHWKNbVN8+nsfL xqeT3yW3LWOHu5MrMJvbpvSsUfPPl13A6vGG9l94xkkTJHtxmmJDhOQgEYHsvJYo/54RVv GmpdWreV5aesStz+oH8c8XJcGJCzYsA1GlrfKZorqY2VFh0e50WGtQmFFQ3tkpIdsZDrq0 MaHqK7a+aZula1l86VcXYKhgYlHDGnDXe/jhu4+r/lLMUciUGEUbxHLugcYFug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684614754; a=rsa-sha256; cv=none; b=kEN4teDWe6SqqTJct9/+iDVu5cPB3Lh34mduIuv9gj3Q6bue440S3KeQWAzpNZyjSfhYcJ d/AA4RWQpdTz4evIGskZ0X87umKhneYcWqDOrVPpUCn4wgfqyvw5kn1Z7zKAsRMrNCAEyh s3f+poKjVHhDjlkaeNKwVzIWB7z3jGWLB6NmCZL8/YoOwbPcBXBEGfuEISk9RhEWc14hF3 vL8xp4kthgEVavAXjnBOtR/fmhPbeOTtGTP5R4Bqm7UgOB+lcECvmjsNTsB3HJdZAi6VG1 BoO9CtzggGseFmkWn2GwpVt2YQW4TTd4GgQeBzwAdiIHk6aW8R+dyeuDdpcfGg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QNwPZ1bPmzPJC for ; Sat, 20 May 2023 20:32:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34KKWYXK079518 for ; Sat, 20 May 2023 20:32:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34KKWYvB079517 for ports-bugs@FreeBSD.org; Sat, 20 May 2023 20:32:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269566] New port: lang/mlkit Date: Sat, 20 May 2023 20:32:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269566 --- Comment #6 from Robert Clausecker --- (In reply to serpent7776 from comment #5) Thank you for your updated patch. Here are some questions I have: - it's USE_GCC, not USE_gcc. I can fix that on commit. - The test target is not run by default and should not be made dependent on an option. It's purpose is to permit testing the port at build time. - Your port now no longer installs any test files, not even if the TEST op= tion is set. So why is this option provided? Your original patch installed a bunch of test files, so I'm a bit confused as to what your intent is. If your intent was to install test files when "make test" is executed, plea= se don't do that. Instead install them if the TEST option is provided, per= haps in a separate install target (such as do-install-TEST-on, which is run o= nly if=20 the TEST option is enabled). - please don't hard code a path to bash as the configure shell. I can pat= ch this to just say CONFIGURE_SHELL=3D bash. Will proceed with a build test once I have a response to these questions. --=20 You are receiving this mail because: You are the assignee for the bug.=