Date: Sat, 20 May 2023 20:32:34 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269566] New port: lang/mlkit Message-ID: <bug-269566-7788-pLIMxtHvGn@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-269566-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-269566-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269566 --- Comment #6 from Robert Clausecker <fuz@FreeBSD.org> --- (In reply to serpent7776 from comment #5) Thank you for your updated patch. Here are some questions I have: - it's USE_GCC, not USE_gcc. I can fix that on commit. - The test target is not run by default and should not be made dependent on an option. It's purpose is to permit testing the port at build time. - Your port now no longer installs any test files, not even if the TEST op= tion is set. So why is this option provided? Your original patch installed a bunch of test files, so I'm a bit confused as to what your intent is. If your intent was to install test files when "make test" is executed, plea= se don't do that. Instead install them if the TEST option is provided, per= haps in a separate install target (such as do-install-TEST-on, which is run o= nly if=20 the TEST option is enabled). - please don't hard code a path to bash as the configure shell. I can pat= ch this to just say CONFIGURE_SHELL=3D bash. Will proceed with a build test once I have a response to these questions. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-269566-7788-pLIMxtHvGn>