From owner-freebsd-current@FreeBSD.ORG  Wed Jan 24 15:45:43 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3E95616A406
	for <current@freebsd.org>; Wed, 24 Jan 2007 15:45:43 +0000 (UTC)
	(envelope-from moellera@googlemail.com)
Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.168])
	by mx1.freebsd.org (Postfix) with ESMTP id D149B13C45D
	for <current@freebsd.org>; Wed, 24 Jan 2007 15:45:42 +0000 (UTC)
	(envelope-from moellera@googlemail.com)
Received: by ug-out-1314.google.com with SMTP id o2so181882uge
	for <current@freebsd.org>; Wed, 24 Jan 2007 07:45:41 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=beta;
	h=received:message-id:date:user-agent:mime-version:to:subject:content-type:content-transfer-encoding:from;
	b=dG3rhUQ9lii3m/6FfWKBEu/SV2oSNc3UtgsCCAre18dO3OsFmNFIpGb3Qh0EbsUQAecY31WsUit83Wpzbg1KjmTGSJCODntGZrNjSNhxtgMld+Ip8nAdNfGP5MD73IFNbvgLyrpBU4qphHGzpIIVtLl5A8hh1Xf9bvfaiR67BdE=
Received: by 10.66.242.20 with SMTP id p20mr1174664ugh.1169651837200;
	Wed, 24 Jan 2007 07:17:17 -0800 (PST)
Received: from ?192.168.0.2? ( [80.132.233.142])
	by mx.google.com with ESMTP id 27sm1147193ugp.2007.01.24.07.17.16;
	Wed, 24 Jan 2007 07:17:16 -0800 (PST)
Message-ID: <45B778DD.4060204@gmail.com>
Date: Wed, 24 Jan 2007 16:18:53 +0100
User-Agent: Thunderbird 1.5.0.9 (Windows/20061207)
MIME-Version: 1.0
To: current@freebsd.org
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
From: Andreas Moeller <moellera@googlemail.com>
Cc: 
Subject: [PATCH] if_em comments
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jan 2007 15:45:43 -0000

Hello,

there are two tiny errors in if_em.c.  Sorry for wasting your time. ;-)

--- if_em.c~    2007-01-24 16:06:15.000000000 +0100
+++ if_em.c     2007-01-24 16:06:53.000000000 +0100
@@ -806,7 +806,7 @@
                          * XXX
                          * Since resetting hardware takes a very long time
                          * and results in link renegotiation we only
-                        * initialize the hardware only when it is 
absolutely
+                        * initialize the hardware when it is absolutely
                          * required.
                          */
                         ifp->if_flags |= IFF_UP;
@@ -2103,7 +2103,7 @@
         adapter->hw.hw_addr = (uint8_t 
*)&adapter->osdep.mem_bus_space_handle;

         if (adapter->hw.mac_type > em_82543) {
-               /* Figure our where our IO BAR is ? */
+               /* Figure out where our IO BAR is ? */
                 for (rid = PCIR_BAR(0); rid < PCIR_CIS;) {
                         val = pci_read_config(dev, rid, 4);
                         if (EM_BAR_TYPE(val) == EM_BAR_TYPE_IO) {