From owner-cvs-all@FreeBSD.ORG Fri Aug 3 23:13:51 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A087316A417; Fri, 3 Aug 2007 23:13:51 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A402F13C461; Fri, 3 Aug 2007 23:13:51 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l73NDpjn087172; Fri, 3 Aug 2007 23:13:51 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l73NDpwM087171; Fri, 3 Aug 2007 23:13:51 GMT (envelope-from bde) Message-Id: <200708032313.l73NDpwM087171@repoman.freebsd.org> From: Bruce Evans Date: Fri, 3 Aug 2007 23:13:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs msdosfs_fat.c msdosfs_vfsops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2007 23:13:51 -0000 bde 2007-08-03 23:13:51 UTC FreeBSD src repository Modified files: sys/fs/msdosfs msdosfs_fat.c msdosfs_vfsops.c Log: Oops, fix the fix for the i/o size of the fsinfo block. Its log message explained why the size is 1 sector, but the code used a size of 1 cluster. I/o sizes larger than necessary may cause serious coherency problems in the buffer cache. Here I think there were only minor efficiency problems, since a too-large fsinfo buffer could only get far enough to overlap buffers for the same vnode (the device vnode), so mappings are coherent at the page level although not at the buffer level, and the former is probably enough due to our limited use of the fsinfo buffer. Approved by: re (kensmith) Revision Changes Path 1.43 +1 -1 src/sys/fs/msdosfs/msdosfs_fat.c 1.168 +1 -1 src/sys/fs/msdosfs/msdosfs_vfsops.c