From nobody Sun Feb 15 08:58:46 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fDKZc1H16z6SGmq for ; Sun, 15 Feb 2026 08:58:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fDKZb1PhSz46fQ for ; Sun, 15 Feb 2026 08:58:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771145927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kAHwXSd/0UZFwurs6aW9Gm94YHu5CVhp6S0q++Q4FBk=; b=uIkc/I73phdH1bQTbF0GLNF+6tsPF58FUMzNZyw6SCqgQdCLqpbkoekob9ODcZgT+fdX4b d50HqZweh2OiFtXORjzclVBZy2nMwfvukNxtxtMIUN5QdzH18vbY8qubiWXmcPpsGITdVt BySpqr2TVjKlYjZgyRLhMY/Yuibpg/0lSuEiA7Jmsha+JC99AEu5qIXea30zzgZKfQSDdT 0jyFYpTv9IHnxe/gQXZx25byLs7SOok5WQYPUZl18qIoyuM3IovHK2n3Dk61S1d0VRVTrF EAnOqAFomkvviezWImUaDRpUNsdjeLMboROGL8UHvjMll+lNtxnkArixvpnGjg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771145927; a=rsa-sha256; cv=none; b=uUc7A6DAfA5t/6K9XcekGfuoV5uXy+km3iWU0p5A702wlMlgVrVlPK6byx1RRUXEHrdWfz WVMMo9Herq09p/f6R+iwbXl/F04ySmFBek8mp83tliPOhiZp/V6SfgSRP2F5CRKw0fJZ1T pxksK7fUC4MnCbJojRbQM+vbR5OjC5tdl04e5DCF814hKbYZKMW0RNrLg+AIcHPKTPykwA 6kq+XDjYodYV8qkniBY9BXGkPjCp30RIN7yvNCL3LkhndqcMXYCJpiBVia8lBo+xYl8Buy J3B561m3vQ74tylokz7g/wRXAfZAPZui2p/WTuQwQk40Cx717pgt/dwUPRaMuA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771145927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kAHwXSd/0UZFwurs6aW9Gm94YHu5CVhp6S0q++Q4FBk=; b=W8rAoY0gB7XnSGldoeETtXN4LJKcKyEJ6N7k9DtHWsx0ccDPM6mfNmnotMcoYwohR2L1oI hDREZRQw/OJToPepu3ct74KLCAqyp13f9ooFoHT13A+44csQon6J0jxHsEcYIEEnAqzChc 7a5nRWCPvCp3lZqmAxMMV7CnvnNVBvnaCJi70328G1GH24XFDsmbpQIz7EtGhGOg3nJqcZ hnOiCT2ydBqfm7jQKnDpNb7UTNII4Tb1rNyVoDzP/hPJvM4tsq8wM/BMcNUwqR2OfR799F l1hFjpuXTqg6Ic1ENuZSg9bjREVGMuh6q0tSItBywP60VdtO/rgqdV9YltJedg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fDKZZ68V1zmL0 for ; Sun, 15 Feb 2026 08:58:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c239 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Feb 2026 08:58:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 84090186db73 - stable/14 - pwd: Error out if writing to stdout failed List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 84090186db732c299fd58f45d1396df1ff866920 Auto-Submitted: auto-generated Date: Sun, 15 Feb 2026 08:58:46 +0000 Message-Id: <69918ac6.1c239.5bbc117f@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=84090186db732c299fd58f45d1396df1ff866920 commit 84090186db732c299fd58f45d1396df1ff866920 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-11 02:06:41 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-15 08:58:34 +0000 pwd: Error out if writing to stdout failed POSIX requires us to print a diagnostic and return a non-zero exit code if writing to stdout failed. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55227 (cherry picked from commit 5b398611607b0dab2f2550ef73f62d41dab6fac5) --- bin/pwd/pwd.c | 2 ++ bin/pwd/tests/pwd_test.sh | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/bin/pwd/pwd.c b/bin/pwd/pwd.c index e8ce4cabc01a..d2d8fac4e4b2 100644 --- a/bin/pwd/pwd.c +++ b/bin/pwd/pwd.c @@ -124,5 +124,7 @@ main(int argc, char *argv[]) printf("%s\n", pwd); else err(1, "."); + if (fflush(stdout) != 0) + err(1, "stdout"); exit(0); } diff --git a/bin/pwd/tests/pwd_test.sh b/bin/pwd/tests/pwd_test.sh index e418e56a89fa..a8805582cc4d 100644 --- a/bin/pwd/tests/pwd_test.sh +++ b/bin/pwd/tests/pwd_test.sh @@ -66,8 +66,29 @@ physical_body() atf_check -o inline:"$root/phy/baz\n" pwd -L } +atf_test_case stdout +stdout_head() +{ + atf_set descr "error writing to stdout" +} +stdout_body() +{ + pwd=$(which pwd) + [ -f "$pwd" ] || atf_skip "unable to distinguish binary from builtin" + ( + trap "" PIPE + # Give true(1) some time to exit. + sleep 1 + $pwd 2>stderr + echo $? >result + ) | true + atf_check -o inline:"1\n" cat result + atf_check -o match:"stdout" cat stderr +} + atf_init_test_cases() { atf_add_test_case logical atf_add_test_case physical + atf_add_test_case stdout }