From owner-cvs-all Sun Mar 11 15:28:47 2001 Delivered-To: cvs-all@freebsd.org Received: from moby.geekhouse.net (moby.geekhouse.net [64.81.6.36]) by hub.freebsd.org (Postfix) with ESMTP id 9EFE137B71A; Sun, 11 Mar 2001 15:28:40 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@dhcp152.geekhouse.net [192.168.1.152]) by moby.geekhouse.net (8.11.0/8.9.3) with ESMTP id f2BNU2157487; Sun, 11 Mar 2001 15:30:10 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Sun, 11 Mar 2001 15:28:04 -0800 (PST) From: John Baldwin To: Dag-Erling Smorgrav Subject: Re: cvs commit: src/sys/alpha/include mutex.h src/sys/i386/inclu Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jake Burkholder Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 11-Mar-01 Dag-Erling Smorgrav wrote: > Jake Burkholder writes: >> > 1.106 +5 -1 src/sys/kern/kern_fork.c > > This one's wrong. It sets p2->p_spinlocks to 1 unconditionally, but if > the kernel was compiled with WITNESS_SKIPSPIN, p_spinlocks is not > decremented when the sched_lock is released, so mtx_legal2block() > always fails and the kernel panics during boot. See the panic and > backtrace I posted to -CURRENT. Ugh, ok. I know how to fix this, and will do so in the new witness code I'm about halfway through. Just don't use skipspin for the time being. I would only turn it on if spinlocks give you problems (which they shouldn't). > DES > -- > Dag-Erling Smorgrav - des@ofug.org -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message