From owner-svn-src-all@freebsd.org  Thu Jul 19 20:27:39 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F21A104957B;
 Thu, 19 Jul 2018 20:27:39 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 051977A17E;
 Thu, 19 Jul 2018 20:27:39 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id F1744312B; Thu, 19 Jul 2018 20:27:38 +0000 (UTC)
Date: Thu, 19 Jul 2018 20:27:38 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Michael Tuexen <tuexen@freebsd.org>
Cc: cem@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers <src-committers@freebsd.org>
Subject: Re: svn commit: r336503 - in head/sys: netinet netinet6
Message-ID: <20180719202738.GA69018@FreeBSD.org>
References: <201807191933.w6JJXhof018383@repo.freebsd.org>
 <CAG6CVpWMWAZW_K47X1kXFS-JJo8Nc3zewKCzjRb7tr5BUsRAUA@mail.gmail.com>
 <F9ECD259-049F-45FB-A104-678749564BCC@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F9ECD259-049F-45FB-A104-678749564BCC@freebsd.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jul 2018 20:27:39 -0000

On Thu, Jul 19, 2018 at 04:23:27PM -0400, Michael Tuexen wrote:
> > On 19. Jul 2018, at 16:11, Conrad Meyer <cem@freebsd.org> wrote:
> > These changes mostly seem like style regressions, rather than
> > improvements.  (Not to mention, largescale churn like this makes it
> > more difficult for future readers to research history (confusing tools
> > like "git/svn blame").)
> 
> We have upstream code and run this to an formatter tool which depends
> on ident, which has been changed recently. Unfortunately, I also ran
> an older version of the script, so I reverted this in
> https://svnweb.freebsd.org/changeset/base/336508
> and committed a version really only showing the differences related to
> the ident changes in
> https://svnweb.freebsd.org/changeset/base/336511

Thanks for fixing, but you might find doing "svn diff" prior to commit
very handy next time (no offense).

./danfe